{ "id": "176163", "key": "TIMOB-28425", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "21199", "description": "", "name": "Release 10.0.1", "archived": false, "released": true, "releaseDate": "2021-07-28" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2021-05-26T15:33:15.000+0000", "created": "2021-04-24T02:24:04.000+0000", "priority": { "name": "Medium", "id": "3" }, "labels": [ "android", "breaking-change", "material-design", "picker" ], "versions": [], "issuelinks": [], "assignee": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2021-05-26T15:33:15.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "*Summary:*\r\nWhen a {{Ti.UI.Picker}} of type {{PICKER_TYPE_PLAIN}} is set up with \"useSpinner\" set to {{true}}, it uses a custom spinner which looks just like the old iOS spinner widget. It should use Android's native Java [NumberPicker|https://developer.android.com/reference/android/widget/NumberPicker] view which would support colors defined in theme, support dark/light theme switching, and correclty DPI scale.\r\n\r\n*Test:*\r\nBuild and run [^SpinnerSimpleTest.js] on Android.\r\n\r\n*Current Result:*\r\nDisplays a custom picker that looks like the old iOS spinner widget. Does not support colors defined by Android theme. Does not support dark/light theme.\r\n !Spinner-Light-Old.png|thumbnail! !Spinner-Dark-Old.png|thumbnail! \r\n\r\n*Expected Result:*\r\nWe should change it to use native Android spinners which appear as...\r\n !Spinner-Light-New.png|thumbnail! !Spinner-Dark-New.png|thumbnail! \r\n\r\n*Note:*\r\nOnce we replace it with the native {{NumberPicker}} Java view, we can remove the custom \"kankan\" spinner Java classes from our SDK here...\r\nhttps://github.com/appcelerator/titanium_mobile/tree/master/android/modules/ui/src/java/kankan/wheel/widget\r\n", "attachment": [ { "id": "67875", "filename": "Spinner-Dark-New.png", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2021-04-24T02:19:37.000+0000", "size": 420506, "mimeType": "image/png" }, { "id": "67877", "filename": "Spinner-Dark-Old.png", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2021-04-24T02:19:37.000+0000", "size": 439920, "mimeType": "image/png" }, { "id": "67876", "filename": "Spinner-Light-New.png", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2021-04-24T02:19:37.000+0000", "size": 419997, "mimeType": "image/png" }, { "id": "67878", "filename": "Spinner-Light-Old.png", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2021-04-24T02:19:37.000+0000", "size": 442611, "mimeType": "image/png" }, { "id": "67879", "filename": "SpinnerSimpleTest.js", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2021-04-24T02:12:04.000+0000", "size": 935, "mimeType": "application/x-javascript" } ], "flagged": false, "summary": "Android: Change \"plain\" Ti.UI.Picker to use native spinners", "creator": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "environment": null, "comment": { "comments": [ { "id": "458612", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "body": "PR (master): https://github.com/appcelerator/titanium_mobile/pull/12745", "updateAuthor": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2021-04-24T05:29:53.000+0000", "updated": "2021-04-24T05:29:53.000+0000" }, { "id": "458713", "author": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "body": "merged to master and 10_0_X for 10.0.1 target", "updateAuthor": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "created": "2021-05-26T15:33:12.000+0000", "updated": "2021-05-26T15:33:12.000+0000" } ], "maxResults": 2, "total": 2, "startAt": 0 } } }