Titanium JIRA Archive
Appcelerator Community (AC)

[AC-5036] Android: Change in behaviour for the on-screen nav buttons displayed

GitHub Issuen/a
TypeBug
Priorityn/a
StatusClosed
ResolutionFixed
Resolution Date2017-07-05T18:03:23.000+0000
Affected Version/sn/a
Fix Version/sn/a
ComponentsTitanium SDK & CLI
Labelsn/a
ReporterMuhammad Ahmed Fahad
AssigneeYordan Banev
Created2017-06-19T04:09:41.000+0000
Updated2017-07-05T18:03:23.000+0000

Description

Environment: 6.1.1.v20170615113917 Android 7.1.2 Device: OnePlus One (A0001) Affected version 6.1.0, 6.1.1 Whilst using the module dk.napp.drawer (https://github.com/viezel/NappDrawer) the lower part of the drawer is now eclipsed by the onscreen-nav-bar on phones which have on screen nav-bars. No issues on phones with capacitive navigation/home buttons. This didn't use to be the case with Ti SDK 6.0.4. Kindly see screenshots for difference in behaviour between 6.0.4 and 6.1.1. With SDK 6.0.4: https://s3-ap-southeast-1.amazonaws.com/uploads-ap.hipchat.com/56929/750866/kgJh35d3Od6bd9L/Screenshot_20170619-115259.png With SDK 6.1.1.v20170615113917: https://s3-ap-southeast-1.amazonaws.com/uploads-ap.hipchat.com/56929/750866/4vbBloyecxgp6cU/with_sdk_6.1.1.v20170615113917.png The module listed is one of the most used 3rd-party modules at least according to: http://gitt.io/ Would be helpful if: a) The difference in behaviour can be resolved at the SDK level or b) The change in behaviour is documented and also ideally a workaround solution

Attachments

FileDateSize
with_sdk_6.0.4.png2017-06-19T03:54:50.000+0000451481
with_sdk_6.1.1.v20170615113917.png2017-06-19T04:02:58.000+0000741065

Comments

  1. Yordan Banev 2017-06-26

    One of the libraries (SlidingMenu) used in the module seems to have a problem which was exposed with the upgrade of the SDK. There are two ways to work around that: - Set the application's targetSDKversion to 19 or below; - Add the following code in android/src/com/slidingmenu/lib/SlidingMenu.java Line:310 
           public void attachToActivity(Activity activity, int slideStyle) {
           attachToActivity(activity, slideStyle, false);
           if(slideStyle == SLIDING_WINDOW && Build.VERSION.SDK_INT >= 21) {
               setSystemUiVisibility(SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION);
           }
       }
    and rebuild the module;
  2. Sharif AbuDarda 2017-06-27

    Hello [~fahad86], Can you follow up on the [~ybanev], comment?
  3. Muhammad Ahmed Fahad 2017-06-28

    Thanks Yordan Banev, I'm using the 2nd workaround and I've submitted a pull request for the module: https://github.com/viezel/NappDrawer/pull/204
  4. Muhammad Ahmed Fahad 2017-07-05

    Sharif/Yordan you can mark this item as resolved

JSON Source