[AC-6050] Alloy does not apply theme defined in config.json

GitHub Issue	n/a
Type	Bug
Priority	n/a
Status	Resolved
Resolution	Done
Resolution Date	2019-01-02T20:56:34.000+0000
Affected Version/s	n/a
Fix Version/s	n/a
Components	Alloy
Labels	CLI7.0.9
Reporter	Brian García
Assignee	Shak Hossain
Created	2018-12-05T08:25:21.000+0000
Updated	2019-01-02T20:58:40.000+0000

Description

Attachments

File	Date	Size
alloy-theme-test.zip	2018-12-05T08:23:46.000+0000	714545

Comments

Brian García 2018-12-05

the issue seems to be related with

   var cRequire = afs.resolvePath(__dirname, '..', 'Alloy', 'commands', 'compile', 'index.js'),
   			config = {
   				theme: cli.argv['theme'] ? cli.argv['theme'] : null,
   				platform: /(?:iphone|ipad)/.test(cli.argv.platform) ? 'ios' : cli.argv.platform,
   				version: '0',
   				simtype: 'none',
   				devicefamily: /(?:iphone|ios)/.test(cli.argv.platform) ? deviceFamily : 'none',
   				deploytype: deployType || cli.argv['deploy-type'] || 'development',
   				target: target
   			};

as it doesn't read the teme property from config.json comparing with an older project

   var cRequire = afs.resolvePath(__dirname, '..', 'Alloy', 'commands', 'compile', 'index.js'),
   			config = {
   				platform: /(?:iphone|ipad)/.test(cli.argv.platform) ? 'ios' : cli.argv.platform,
   				version: '0',
   				simtype: 'none',
   				devicefamily: /(?:iphone|ios)/.test(cli.argv.platform) ? deviceFamily : 'none',
   				deploytype: deployType || cli.argv['deploy-type'] || 'development',
   				target: target
   			};

Ewan Harris 2018-12-05

[~bgarcia], I believe ALOY-1638 fixes this issue as it will now only set the theme property in the config if the --theme flag is passed in.
Brian García 2018-12-05

I see, it turns out that the Alloy plugin packaged with the CLI is not the latest with the fix, so I need to specify my projects to use the global one
Rakhi Mitro 2019-01-02

Hello, Just passing as update here. Are you able to get that sorted out? Please let us know your current status and if you need more help with this issue. Regards, Rakhi
Brian García 2019-01-02

Hi Rakhi, it seems like CLI 7.0.9 fixes this issue. Thanks

JSON Source