[AC-6154] [Docs] Add Titanium.Network.HTTPClient default timeout value
GitHub Issue | n/a |
---|---|
Type | Improvement |
Priority | n/a |
Status | Resolved |
Resolution | Fixed |
Resolution Date | 2019-03-27T21:46:44.000+0000 |
Affected Version/s | n/a |
Fix Version/s | n/a |
Components | Documentation |
Labels | n/a |
Reporter | nicolomonili |
Assignee | Shak Hossain |
Created | 2019-03-05T09:35:53.000+0000 |
Updated | 2019-03-27T21:46:44.000+0000 |
Description
Add the default value of *timeout* property, when the property is not set.
[https://docs.appcelerator.com/platform/latest/#!/api/Titanium.Network.HTTPClient-property-timeout](https://docs.appcelerator.com/platform/latest/#!/api/Titanium.Network.HTTPClient-property-timeout)
For iOS, there is a default value for timeout with 15s/15000ms.
It's not documented but can be found here: [https://github.com/appcelerator/titanium_mobile/blob/master/iphone/Classes/TiNetworkHTTPClientProxy.m#L122](https://github.com/appcelerator/titanium_mobile/blob/master/iphone/Classes/TiNetworkHTTPClientProxy.m#L122)
Hi! Sounds like a perfect PR you could submit if you have some time! Code for the docs can be found here: https://github.com/appcelerator/titanium_mobile/edit/master/apidoc/Titanium/Network/HTTPClient.yml (click edit button on the docs page)
Hello [~nicolomonili], Can you create the PR and attach here? [~bimmel], Please take care of it after the PR is attached. Thanks.
https://github.com/appcelerator/titanium_mobile/pull/10806
Doc change to specify default iOS value has been merged to master branch