[AC-6146] Tab Group

GitHub Issue	n/a
Type	Bug
Priority	n/a
Status	Resolved
Resolution	Duplicate
Resolution Date	2019-03-01T22:25:48.000+0000
Affected Version/s	n/a
Fix Version/s	n/a
Components	Titanium SDK & CLI
Labels	n/a
Reporter	Andreas Pingas
Assignee	Shak Hossain
Created	2019-02-20T14:48:17.000+0000
Updated	2019-03-01T22:25:49.000+0000

Description

At Android devices when you first launch the app and the device is horizontal the tab group appears as follow when you rotate it to the vertical position.

Attachments

File	Date	Size
52397761_1961077823989408_2806662798954725376_n.png	2019-02-20T14:47:38.000+0000	10609

Comments

Joshua Quick 2019-02-20

This is not a bug and was made this way on purpose. In Titanium 8.0.0, Android's TabGroup has been completely rewritten to use Google's newest native tab classes. Our old implementation displayed tabs in the ActionBar and has been deprecated by Google. The benefits of this change is that you can now use a "NoTitleBar" theme. You weren't able to do this before since tabs used to be embedded within it. The other benefit of our TabGroup rewrite is that Android now supports a "bottom" tab style similar to iOS. The negative is that the top tab bar style will appear below the ActionBar when landscape (as you've noted) since they're no longer embedded within the ActionBar. If you don't like this behavior, then I recommend that you use the "NoTitleBar" theme instead... which is how it's normally displayed in iOS as well.
Andreas Pingas 2019-02-22
Sharif AbuDarda 2019-02-22

Hello [~andreas.pingas], I tried to test the issue on the ticket above, I was able to reproduce it on a device (Nokia 6 Android 8.1.0). I am testing with the SDK 8.0.0.v20190219113758. launching a TabGroup in "portrait" form, In landscape mode tabs are resized and when going back to portrait mode the tabs stretch to fit the window. But, launching a TabGroup in "landscape" form, In portrait mode, the tabs won't resize to fill the window. Thanks.
Joshua Quick 2019-02-22

bq. Also, TabGroup with bottom style, is it obligatory to have title at tabs? You do not have to set a title, but it'll still render a small empty space where the title would normally be. This is a feature that Google has added fairly recently (support library v28) which we haven't upgraded to yet (Titanium is using v27). So, this is a thing we can do in the future once [TIMOB-26262] is done.
Andreas Pingas 2019-02-23

Thanks for the update
Sharif AbuDarda 2019-03-01

Closing this as a duplicate of TIMOB-26698. Thanks.

JSON Source