Titanium JIRA Archive
Alloy (ALOY)

[ALOY-1002] Platform-specific folders within a widget's assets are copied unnecessarily to the Resources folder

GitHub Issuen/a
TypeBug
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2014-08-13T14:07:11.000+0000
Affected Version/sn/a
Fix Version/sAlloy 1.5.0
ComponentsTooling
Labelsqe-manualtest
ReporterTim Poulsen
AssigneeFeon Sua Xin Miao
Created2014-05-01T17:42:49.000+0000
Updated2014-09-12T03:02:06.000+0000

Description

Consider a widget with assets including assets in platform-specific folders.

Expectation

After compilation, those assets should exist only under Resources/widget_name not in Resources/platform_name/widget_name.

Actual

Assets exist in both locations

Comments

  1. Feon Sua Xin Miao 2014-05-15

    Test case: app/themes/plusminus/widgets/starrating/assets/ios/star_half.png (a logo) app/themes/plusminus/widgets/starrating/assets/android/star_half.png (blue circle) app/themes/plusminus/widgets/starrating/assets/foo.png (brown circle) app/themes/plusminus/widgets/starrating/assets/star.png (plus) app/themes/plusminus/widgets/starrating/assets/star_off.png (minus) app/widgets/starrating/assets/ios/star.png (red) app/widgets/starrating/assets/android/star.png (green) app/widgets/starrating/assets/star.png (yellow) app/widgets/starrating/assets/star_half.png (half) app/widgets/starrating/assets/star_off.png (off) ------ After compilation, there are some unnecessary files: iphone Resources/iphone/ios/starrating/star.png (red) Resources/iphone/starrating/ios/star_half.png (a logo) Resources/iphone/starrating/android/star_half.png (blue circle) Resources/iphone/starrating/foo.png (brown circle) Resources/iphone/starrating/star.png (red) Resources/iphone/starrating/star_half.png (a logo) Resources/iphone/starrating/star_off.png (minus) — android Resources/android/ios/starrating/star.png (red) Resources/android/starrating/ios/star_half.png (a logo) Resources/android/starrating/android/star_half.png (blue circle) Resources/android/starrating/foo.png (brown circle) Resources/android/starrating/star.png (plus) Resources/android/starrating/star_half.png (half) Resources/android/starrating/star_off.png (minus)
  2. Feon Sua Xin Miao 2014-05-16

    PR : https://github.com/appcelerator/alloy/pull/426 Test app: https://github.com/feons/alloy/tree/ALOY-1002/test/apps/testing/ALOY-1002 Functional Test: The assets in the test app are organized like this: app/themes/plusminus/widgets/starrating/assets/ios/star_half.png (a logo) app/themes/plusminus/widgets/starrating/assets/android/star_half.png (blue circle) app/themes/plusminus/widgets/starrating/assets/foo.png (brown circle) app/themes/plusminus/widgets/starrating/assets/star.png (plus) app/themes/plusminus/widgets/starrating/assets/star_off.png (minus) app/widgets/starrating/assets/ios/star.png (red) app/widgets/starrating/assets/android/star.png (green) app/widgets/starrating/assets/star.png (yellow) app/widgets/starrating/assets/star_half.png (half) app/widgets/starrating/assets/star_off.png ( off ) So, after compilation the Resources folder should have these files and no platform-specific folders: For iphone: Resources/iphone/starrating/star_half.png (a logo) Resources/iphone/starrating/star.png (red) Resources/iphone/starrating/foo.png (brown circle) Resources/iphone/starrating/star_off.png (minus) For android: Resources/android/starrating/star_half.png (blue circle) Resources/android/starrating/star.png (green) Resources/android/starrating/foo.png (brown circle) Resources/android/starrating/star_off.png (minus) For mobileweb: Resources/mobileweb/starrating/star_half.png (half) Resources/mobileweb/starrating/star.png (plus) Resources/mobileweb/starrating/foo.png (brown circle) Resources/mobileweb/starrating/star_off.png (minus) ---- The ordering goes like this from highest to lowest priority: themed widget platform-specific assets widget platform specific assets themed widget non-platform-specific assets widget non-platform-specific assets
  3. Tim Poulsen 2014-06-05

    PR tested and merged
  4. Feon Sua Xin Miao 2014-08-05

    app/widgets/<widget name>/assets/ios folder is copied to Resources folder for all platforms, reopening to track implementing the fix.
  5. Feon Sua Xin Miao 2014-08-13

    PR: https://github.com/appcelerator/alloy/pull/506 Run this from repo directory, after compilation the Resources folder should not have platform-specific folders: 
    jake app:run dir=ALOY-1002
     There should be no image not found error messages when running this: 
    jake app:run dir=ALOY-898
  6. Tim Poulsen 2014-08-13

    PR merged
  7. Federico Casali 2014-09-12

    Verified fixed. TiSDK 3.4.0.v20140911135715 Appcelerator Studio 3.4.0.201409111151 CLI 3.4.0-rc2 Alloy 1.5.0-rc Xcode6-beta7 Closing.

JSON Source