[ALOY-1081] Improve query selection speed through sync adapter optimizations
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Medium |
| Status | Resolved |
| Resolution | Fixed |
| Resolution Date | 2014-08-20T04:00:54.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Alloy 1.7.0 |
| Components | Models |
| Labels | n/a |
| Reporter | Tim Poulsen |
| Assignee | Tim Poulsen |
| Created | 2014-07-09T14:27:54.000+0000 |
| Updated | 2019-05-15T14:11:18.000+0000 |
Description
Community-submitted pull request: https://github.com/appcelerator/alloy/pull/471
Speed improvements for selecting data
Attachments
| File | Date | Size |
|---|---|---|
| pr471.zip | 2014-08-19T16:01:59.000+0000 | 5939875 |
Test app attached - create a new Alloy project and replace its app folder with the attached.
Using the test app attached, I see a roughly 20% improvement on iOS. However, the app crashes on Android. MobileWeb and BlackBerry are yet untested. I added a comment to the PR.
Updated test app attached. Uses more complex model definition to more closely match the app provided in the source pull request.
PR: https://github.com/appcelerator/alloy/pull/510 Functional test: 1. Run the attached test app for iOS and Android (Blackberry too, if your system is configured for that). It should run without errors. The log output contains an elapsed time measure (shows up as "Diff: xx seconds"). This is the time needed to retrieve the rows from the DB, loop through the collection, and output. Optionally, you can run this same test app against 1.4.1 to see the speed improvement of this change. 2. Run any of the apps in the test/apps/models folder -- each should run without errors.
**APPROVED**
PR merged