[ALOY-1096] Alloy: Update moment.js built-in library to latest version.
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Critical |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2014-07-25T14:55:54.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Alloy 1.5.0 |
| Components | Builtins |
| Labels | alloy, built-in, moment.js, qe-manualtest, update |
| Reporter | Ed |
| Assignee | Feon Sua Xin Miao |
| Created | 2014-07-03T22:15:03.000+0000 |
| Updated | 2014-08-19T00:00:30.000+0000 |
Description
The latest version of the moment.js library is v2.7.0, yet Alloy includes an outdated version 2.1.0 as a built in.
There are new features and bug fixes on the new version that we could use. As of now, we have to include moment 2.7.0 as a stand-alone lib on our Alloy project for these new features and cannot use the built-in.
Original reporter: Ed. The system forces a change to the reporter when I move this bugs from Community to Alloy.
PR : https://github.com/appcelerator/alloy/pull/491
Perhaps moment changed how it handles languages, because the apps/advanced/momentjs example app is not working as expected with your change. The language of the date output string is not updating as it should. Would you make sure that the app is using the correct techniques, and if necessary update the language files.
updated PR.
Unfortunate that we have to modify moment.js to include it within Alloy. However, that's what was done in previous versions. The test apps all work now. Thanks! PR merged to 1.5.x master branch
As specified in the package.json file, Moment version is 2.7.0 Samples work as expected. TiSDK 3.4.0.v20140813022514 Appcelerator Studio 3.3.1.201408121314 CLI 3.4.0-dev Alloy 1.5.0-dev Xcode6-beta5 Closing