[ALOY-1098] Support actionView property of MenuItem in XML markup
GitHub Issue | n/a |
---|---|
Type | New Feature |
Priority | Medium |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2014-10-27T14:34:17.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Alloy 1.6.0 |
Components | XML |
Labels | TCSupport, alloy, alloy-cli, android |
Reporter | Manojkumar Murugesan |
Assignee | Tim Poulsen |
Created | 2014-07-09T09:20:17.000+0000 |
Updated | 2015-03-26T16:45:27.000+0000 |
Description
<Menu>
<MenuItem>
<ActionView>
<View backgroundColor="#fff" />
</ActionView>
</MenuItem>
</Menu>
Set actionView of MenuItem using alloy xml markup
Original reporter: [~mano_mykingdom]. Thanks for your report!
Tony, if you can add the label TCSupport, would be awesome. Thanks!
PR https://github.com/appcelerator/alloy/pull/585 Functional test: 1) Run the included ALOY\-1098 project for Android. The ActionBar should have a menu and two items: search and a generic "Click" button. Click the search icon to expand the action view. (The field is just a text field, not a true searchView so entering text won't do anything). Click the home icon to collapse the action view. 2) Test the ALOY\-994 and ui/android_menu test apps should run without error.
PR merged.
Reopen to backport to 1_6_X branch
PR for 1_6_X: https://github.com/appcelerator/alloy/pull/606 This PR also contains a fix for ALOY-1175 because they are dependent upon each other. Sorry to mix two tickets in one PR.
PR merged.
Verified fixed using: Titanium SDK 4.0.0.v20150325201813 Studio 4.0.0.201503232213 Appc NPM: 0.3.35 Appc CLI 0.2.191 Alloy 1.6.0-alpha On: Note 2, Android 4.3 Able to use actionView property of MenuItem without error or warning.