Titanium JIRA Archive
Alloy (ALOY)

[ALOY-1112] Styles TSS: Support spaces in comma-separated lists of targets in the platform attribute

GitHub Issuen/a
TypeImprovement
PriorityNone
StatusResolved
ResolutionFixed
Resolution Date2014-08-11T15:02:32.000+0000
Affected Version/sn/a
Fix Version/sn/a
ComponentsStyling
Labelsn/a
ReporterFederico Casali
AssigneeFeon Sua Xin Miao
Created2014-08-08T17:08:01.000+0000
Updated2014-08-11T15:43:35.000+0000

Description

Improvement description

See ALOY-1090 Spaces in comma-separated lists of targets in the platform attribute could be supported also in styles .TSS. For example: 1. Create a new project and use the following code:
'#index[platform=android, ios]': {
	backgroundColor: 'yellow',
	fullscreen: false,
	exitOnClose: true
}
2. Run on android and ios. Result: In this case, no errors are displayed and the only the first target is (android) is currently recognized and styles applied. Expected result: Both target platforms should be recognized.

Comments

  1. Feon Sua Xin Miao 2014-08-11

    PR: https://github.com/appcelerator/alloy/pull/504 Test app: https://github.com/feons/alloy/tree/ALOY-1112/test/apps/testing/ALOY-1112 Functional Test: 1. Run the test app on ios, android and mobile web. 2. Background color should be {color:yellow}yellow{color} on ios & android, white on mobile web 3. 2nd label should be {color:red}red{color} on iphone & android handheld, black on other platforms.
  2. Tim Poulsen 2014-08-11

    Looks good, but would you update the code per the comment I posted on the PR?
  3. Feon Sua Xin Miao 2014-08-11

    Updated PR. Thanks [~skypanther]!
  4. Tim Poulsen 2014-08-11

    PR merged

JSON Source