[ALOY-1177] Implicitly set ns attribute for SearchView to Ti.UI.Android
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Medium |
| Status | Resolved |
| Resolution | Fixed |
| Resolution Date | 2014-10-30T04:53:28.000+0000 |
| Affected Version/s | Alloy 1.6.0 |
| Fix Version/s | Alloy 1.7.0 |
| Components | XML |
| Labels | n/a |
| Reporter | Benjamin Hatfield |
| Assignee | Tim Poulsen |
| Created | 2014-10-21T22:02:28.000+0000 |
| Updated | 2014-10-30T04:53:28.000+0000 |
Description
When declaring a SearchView element in XML markup, Alloy should assign it the 'Ti.UI.Android' namespace. Alloy is currently doing this for a lot of iOS-specific components.
These two items should be equivalent.
<SearchView ns="Titanium.UI.Android"/>
<SearchView/>
PR https://github.com/appcelerator/alloy/pull/617 Functional test: Included in the PR is test/apps/testing/ALOY\-1177. It contains a TableView with a SearchView, the tag for which has no attributes (
<SearchView/>). 1. Run it for Android and confirm that the SearchView appears and is functional. 2. Run it for iOS; you should get a WARN message in the log output stating that the tag is for Android only. But, the app should still build and run just without the search view component. 3. Edit the index.xml file to use either of the alternate commented-out tags and build for Android or iOS. The app should run as previously described. Net result [~bhatfield] is that bothns="Ti.UI.Android"andplatform="android"are optional now.PR merged.