[ALOY-1191] Star-rating image aspect ratio styles
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | None |
| Status | Closed |
| Resolution | Invalid |
| Resolution Date | 2014-12-02T16:58:21.000+0000 |
| Affected Version/s | Alloy 1.5.1 |
| Fix Version/s | n/a |
| Components | Samples & Templates |
| Labels | n/a |
| Reporter | Tim Statler |
| Assignee | Tim Poulsen |
| Created | 2014-12-01T14:25:33.000+0000 |
| Updated | 2018-03-07T22:28:28.000+0000 |
Description
Steps:
1. Run the https://github.com/appcelerator/alloy/tree/master/test/apps/advanced/theming_widgets sample app on iOS and Android and observe star-rating images
Results: Rating images are stretched (see attached).
Expected: Rating images appear at their native aspect ratios.
Note: I think this is probably behaving as expected/designed as a test app, but still looks off. One solution is to remove either the height or width TSS style settings in the theme or widget's styles/star.tss file, so the image is resized proportionately,
'.star': {
height:'32dp',
width: '10dp',
left:'8dp'
}
Attachments
| File | Date | Size |
|---|---|---|
| android_stretch.png | 2014-12-01T14:25:33.000+0000 | 223131 |
| ios_stretch.png | 2014-12-01T14:25:33.000+0000 | 23620 |
[~tstatler] yes, the app is working as designed (ugly as that may be). I wanted to show that properties are merged when applying the theme, as well as showing how widget themes could override base style properties.
Understood. I'd close the ticket invalid but don't appear to have that permission.
Closing as invalid. If this is incorrect, please reopen.