[ALOY-1205] Alloy launch image for 667h has the wrong filename
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2015-04-10T06:48:10.000+0000 |
Affected Version/s | Alloy 1.5.1 |
Fix Version/s | Alloy 1.6.0, Alloy 1.7.0 |
Components | Samples & Templates |
Labels | launchimages, splash |
Reporter | Fokke Zandbergen |
Assignee | Tim Poulsen |
Created | 2014-12-17T16:08:17.000+0000 |
Updated | 2015-04-16T23:40:51.000+0000 |
Description
It is named
Default-Portrait-667h@2x.png
but should be Default-667h@2x.png
like the classic template has:
https://github.com/appcelerator/titanium_mobile/tree/master/iphone/templates/app/default/template/Resources/iphone
PR: https://github.com/appcelerator/alloy/pull/637
PR merged and cherry-picked to 1_6_X
Default-Portrait-667h@2x.png
still exists in the 1_6_X branch. Reopening. Can the incorrect image be removed or the labels be updated to reflect that the fix is only fully in master, currently?1_6_X: https://github.com/appcelerator/alloy/pull/674
[~fokkezb] can you review and merge this if it looks correct?
APPROVED (but I can't merge on Alloy)
Merged.
Verified using: Mac OSX 10.10.2 Titanium SDK build: 4.0.0.v20150415182612 Appc CLI (NPM): 0.3.44 Appc CLI (Registry): 0.2.249 When creating a new alloy app as of 0.2.249 the filename is now Default-667h@2x.png. Closing ticket