[ALOY-1300] iOS: Assets Catalog inconsistency between Alloy and Classic
| GitHub Issue | n/a |
|---|
| Type | Bug |
|---|
| Priority | Critical |
|---|
| Status | Resolved |
|---|
| Resolution | Fixed |
|---|
| Resolution Date | 2015-08-21T02:28:45.000+0000 |
|---|
| Affected Version/s | n/a |
|---|
| Fix Version/s | n/a |
|---|
| Components | Tooling |
|---|
| Labels | n/a |
|---|
| Reporter | Chee Kiat Ng |
|---|
| Assignee | Feon Sua Xin Miao |
|---|
| Created | 2015-08-20T07:54:41.000+0000 |
|---|
| Updated | 2015-08-21T02:31:12.000+0000 |
|---|
Description
Comparing the folders *Assets.xcassets* in the generated build folder between a classic and alloy project, the alloy *AppIcon.appiconset* and *LaunchImage.launchimage* contains inconsistent images, even though the file naming convention is correct. See attached images for comparison.
Steps to reproduce
1. Create a ti classic project: ti create
2. enter project folder
3. Create Alloy: alloy new
4. Compile Alloy: alloy compile --config platform=ios
5. Build project: ti build -p ios -I 9.0
Expected result
images in assets catalog should be consistent
Actual result
appicon-60@2x.png and appicon-60@3x.png is different from the rest
Default-Landscape-736h@3x.png and Default-667h@2x.png and Default-Portrait-736h@3x.png is different from the rest
*Note*: because of this, appc run is seeing the same issue.
Attachments
This is NOT an asset catalog issue. The actual images in the project directory are different: https://github.com/appcelerator/alloy/tree/master/platforms/ios/project/app/assets/iphone. So, we can either A) resolve this ticket as invalid, B) fix all icons to be same branding, or C) remove all app icons except appicon@2x.png. As for the launch images, you can simply either leave them alone or fix the branding in each of them. Since I don't care either way and we don't have an Alloy champion, I'm going to defer to [~ingo] to make the call.
I vaguely remember there's a PR that updated all template assets, https://github.com/appcelerator/alloy/pull/505/files, and then followed by another one that reverted the changes, https://github.com/appcelerator/alloy/pull/522/files. However the changes is not backported to the master branch, and resulted in the inconsistency. To avoid confusion, I'm gonna cherry-pick the back-out change of graphics to master.
yay! Feon to the rescue!
But that PR has the wrong size for the ios appicon@2x.png. Make sure you don't lose that version. It has to be at least 180x180.
https://github.com/appcelerator/alloy/pull/717
PR merged!