[ALOY-1311] Alloy.jmk compile:app.js event never fires
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2015-10-23T20:39:53.000+0000 |
Affected Version/s | alloy 1.7.21 |
Fix Version/s | Release 5.1.0, alloy 1.7.22 |
Components | n/a |
Labels | alloy |
Reporter | Jason Kneen |
Assignee | Feon Sua Xin Miao |
Created | 2015-03-02T16:35:44.000+0000 |
Updated | 2015-11-10T23:15:17.000+0000 |
Description
According to:
https://wiki.appcelerator.org/pages/viewpage.action?pageId=35620079
a "compile:app.js" event fires after the app.js is created and before it's written to disk.
This never happens and the event is ignored.
PR: https://github.com/appcelerator/alloy/pull/734 Test: https://github.com/feons/alloy/tree/ALOY-1311/test/apps/advanced/alloy_jmk
PR merged.
Verified fixed using: MacOS 10.11.2 (15C31f) Studio 4.4.0.201511040454 Ti SDK 5.1.0.v20151110110428 Appc NPM 4.2.1 Appc CLI 5.1.0-45 Ti CLI 5.0.5 Alloy 1.7.24 Arrow 1.3.19 Xcode 7.2 (7C46t) Node v0.12.7 Java 1.7.0_80 production pre:compile and compile:app.js events successfully fire when used in alloy.jmk. Callback functions are run as expected. Tested using provided sample test