[ALOY-1340] Alloy selective compilation broken since ALOY-1332
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2015-12-16T19:43:38.000+0000 |
Affected Version/s | alloy 1.7.29 |
Fix Version/s | Release 5.2.0, alloy 1.7.30 |
Components | Tooling |
Labels | alloy, compiler |
Reporter | Xavier Lacot |
Assignee | Feon Sua Xin Miao |
Created | 2015-12-14T17:32:48.000+0000 |
Updated | 2016-02-02T23:41:50.000+0000 |
Description
Since [this commit](https://github.com/feons/alloy/commit/25855c1f342eecf6cb6e69dca007d05ebde1771b#diff-ddbdb7300fa15590afdfee9246ac61fcR177), Alloy's selective compilation is broken since the
Resources
's alloy.js
file gets replaced each and every time the alloy compile command is called.
Instead, the fix should look if there's a file restriction, and not replace alloy.js
if this restriction does not affect this file.
This is particularly problematic when using some compilation watcher (aka. tishadow + grunt-tishadow), which look for changes in the Resources
folder to re-launch the app. With the current change, the app will be refreshed using a template-based alloy.js
file (not a recompiled one).
A Pull Request fixing this problem is available in https://github.com/appcelerator/alloy/pull/746
PR merged.
Verified fixed, using: MacOS 10.11.3 (15D21) Studio 4.5.0.201601262138 Ti SDK 5.2.0.v20160202103508 Appc NPM 4.2.3-1 Appc CLI 5.2.0-239 Alloy 1.7.33 Xcode 7.2 (7C68)
Alloy.js
is no longer replaced when building selectively with Alloy. Tested with the Alloy CLI and running commands similar to:appc alloy compile --config platform=ios,file=app/controllers/index.js
. The Alloy.js file is not touched with the previous command.