Titanium JIRA Archive
Alloy (ALOY)

[ALOY-1523] Alloy uses old require-paths with new require-behavior

GitHub Issuen/a
TypeBug
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2017-04-10T16:31:18.000+0000
Affected Version/sn/a
Fix Version/sRelease 6.2.0, alloy 1.9.11
ComponentsRuntime
Labelsn/a
ReporterHans Knöchel
AssigneeFeon Sua Xin Miao
Created2016-10-18T18:13:37.000+0000
Updated2017-06-14T20:56:42.000+0000

Description

We introduced an updated require-handling in Titanium 6 that matches the full NodeJS specs for handling all kind of files and data structures. Although we are save for older require-paths, we should update the Alloy-internal require-calls as well. Example log: 
require called with un-prefixed module id: alloy/constants, should be a core or CommonJS module. Falling back to old Ti behavior and assuming it's an absolute path: /alloy/constants
It will only be shown in the DEBUG log-level, but adjusting it internally would be the cleanest way here. Thx!

Comments

  1. Feon Sua Xin Miao 2016-10-26

    PR: https://github.com/appcelerator/alloy/pull/801 *To Test* 1. Select SDK 6.X, appc new -t titanium 2. DEBUG=* appc run -l trace 3. There should be no require called with un-prefixed module id in the output log 4. The app should run with no error 5. Update tiapp.xml to use sdk 5.X, the app should run with no error
  2. Hans Knöchel 2016-10-27

    The PR looks fine (guess you did a regex/find-replace change here?). But as [~cwilliams] removed the debug log for 6.0.0 and it will break backwards compatiblity, we would need to bump Alloy for this as well. I did not think of that before, so we either bump Android to 2.0.0 in 6.0.0 (which is a) a bit too late now and b) not really worth for only this change; people would expect more in a 2.0.0) or we move this to a later Alloy / SDK version. I would suggest the latter for now, especially since there won't be any reports regarding those logs anymore and it does not break any current behavior. Thx!
  3. Feon Sua Xin Miao 2016-10-27

    [~hansknoechel], maybe I have missed something, what's the test case you used that shows the changes break backward compatibility? I tested with *6.0.0.v20161013072802* and *5.5.0.GA*, the app launches fine.
  4. Hans Knöchel 2016-10-27

    [~fmiao] See the comment from Chris in https://github.com/appcelerator/titanium_mobile/pull/8553.
  5. Feon Sua Xin Miao 2016-10-27

    [~hansknoechel], the paths are prefixed with a /, they are resolved relative to the Resources directory. This works in SDK 6.0.0 prior. It should also work in 6.X. https://github.com/appcelerator/titanium_mobile/blob/master/android/runtime/common/src/js/module.js#L262. That said, I do agree that this PR is not a deal breaker.
  6. Hans Knöchel 2016-11-21

    Putting out of review for now, since Alloy 2.0.0 has not been branched if I see it correctly.
  7. Feon Sua Xin Miao 2016-11-22

    This is not a breaking change, why should it go into Alloy 2.0.0?
  8. Hans Knöchel 2016-11-22

    Is was marked for 2.0.0 :-) Happy to accept it earlier then. Probably I even set the version earlier. So would you suggest to put in in the next Alloy version / 6.1.0? You're the Alloy boss :-)
  9. Feon Sua Xin Miao 2016-11-22

    [~hansknoechel], I was curious, because you marked it for 2.0.0. ;) I assume it does break something that I overlooked.
  10. Abir Mukherjee 2017-04-05

    Passed FR with: NPM Version: 3.10.10 Node Version: 6.10.1 Mac OS: 10.12.3 Appc CLI: 6.2.0 Appc CLI NPM: 4.2.9-3 iOS Device: 10 SDK 6.0.3.GA and 5.5.1 Tested with the above environment. "require called with un-prefixed module id" was not seen as it should not have. App works normally in Sim and on Device using SDK 6.0.3 and SDK 5.5.1.
  11. Feon Sua Xin Miao 2017-04-10

    Update fix version.
  12. Sergey Nosenko 2017-06-14

    WPATH generation is still wrong. :( for example Alloy 1.10.2 
        function WPATH(s) {
    	var index = s.lastIndexOf('/');
    	var path = index === -1 ? 'ip.form.manager/' + s : s.substring(0, index) + '/ip.form.manager/' + s.substring(index + 1);
    
    	return false && path.indexOf('/') !== 0 ? '/' + path : path;
    }
  13. Feon Sua Xin Miao 2017-06-14

    [~darknos], created ALOY-1569 to track the issue, thanks for catching this!

JSON Source