[ALOY-1524] Replace wrench with fs-extra
GitHub Issue | n/a |
---|---|
Type | Story |
Priority | None |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2017-08-23T16:43:07.000+0000 |
Affected Version/s | n/a |
Fix Version/s | CLI Release 6.3.0 |
Components | Tooling |
Labels | n/a |
Reporter | Feon Sua Xin Miao |
Assignee | Feon Sua Xin Miao |
Created | 2016-10-18T21:21:50.000+0000 |
Updated | 2017-10-10T00:05:07.000+0000 |
Description
Alloy uses
wrench.js
extensively throughout its code base, however the module have been deprecated. We should replace it with another module to do filesystem operations, i.e. fs-extra.
Started a PR: https://github.com/appcelerator/alloy/pull/822 Linux tests are all green!
Jake tests: * Linux: 1802 specs, 0 failures * Windows: 1796 specs, 0 failures Manual testing: * ti create + alloy new * alloy generate controller/widget * alloy compile OSX is next
*Need some help:* some files are not copied to Resources/ : * underscore.js * widget.js * sync/ Not sure why and where I need to fix that
changed
wrench.readdirSyncRecursive
towalkSync()
now all files are copied over!Node Version: 6.10.3 NPM Version: 3.10.10 Mac OS: 10.13 Appc CLI: 6.2.4 Appc CLI NPM: 4.2.9 Titanium SDK version: 6.2.2 Verified that builds are not broken with the module replacement.