[ALOY-1595] alloy compile broken on node 9.3.0
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | None |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2018-01-30T16:46:32.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | CLI Release 7.0.3 |
| Components | n/a |
| Labels | n/a |
| Reporter | Ewan Harris |
| Assignee | Ewan Harris |
| Created | 2017-12-14T12:10:13.000+0000 |
| Updated | 2018-03-23T22:21:26.000+0000 |
Description
Description
alloy compile is currently broken on node 9.3.0 due to the deasync modules use of undocumented internal apis. We should look to either move away from deasync or fix the use of the internal apis in that module
Reference
https://github.com/abbr/deasync/issues/89
https://github.com/nodejs/node/issues/17678
This is fixed by https://github.com/abbr/deasync/commit/3638d542b6c0fece8d7ddf2a02d9bcd8b1109bcb but is still using node internals
PR: https://github.com/appcelerator/alloy/pull/863 Alloy with deasync@0.1.12 has already be included in appc 7.0.1-5. This pr simply set the min version required.
Closing ticket able to use alloy compile on (7.0.3-master.19)