[ALOY-1640] Modify <TabbedBar/> to use "Ti.UI" instead of "Ti.UI.iOS" for 8.0.0
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | High |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2019-01-15T18:04:43.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | CLI Release 7.0.10, Alloy 1.13.8 |
| Components | n/a |
| Labels | n/a |
| Reporter | Joshua Quick |
| Assignee | Ewan Harris |
| Created | 2018-12-21T03:15:29.000+0000 |
| Updated | 2019-02-18T11:46:36.000+0000 |
Description
*Summary*
Alloy currently creates
TabbedGroup from Ti.UI.iOS only. This needs to change to create it from Ti.UI instead when building with Titanium 8.0.0 and higher.
*Reason:*
We're adding Ti.UI.TabbedBar support to Android in Titanium 8.0.0 for parity with iOS. See: [TIMOB-25953]
iOS currently has it defined under both Ti.UI and Ti.UI.iOS. In Titanium 7.x.x, Ti.UI.TabbedGroup is flagged deprecated, but we plan on reversing that and making Ti.UI.iOS.TabbedGroup deprecated in 8.0.0. See: [TIMOB-26674]
*Note:*
This should probably be implemented similar to how it was done for NavigationWindow here...
https://github.com/appcelerator/alloy/pull/901
PR: https://github.com/appcelerator/alloy/pull/918
Verified the fix in CLI 7.0.10-master.5 containing alloy 1.13.7. Closing. Studio Ver: 5.1.2.201812191831 SDK Ver: 8.0.0 local build OS Ver: 10.14 Xcode Ver: Xcode 10.1 Appc NPM: 4.2.13 Appc CLI: 7.0.10-master.5 Daemon Ver: 1.1.3 Ti CLI Ver: 5.1.1 Alloy Ver: 1.13.7 Node Ver: 8.9.1 NPM Ver: 5.5.1 Java Ver: 10.0.2 Devices: ⇨ google Nexus 5 (Android 6.0.1) ⇨ google Pixel (Android 9)