[ALOY-1648] Include BackboneJS v1.4.0
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Critical |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2019-06-19T22:30:25.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | CLI Release 7.1.0, Alloy 1.14.0 |
| Components | n/a |
| Labels | n/a |
| Reporter | Ahmed Mohamed |
| Assignee | Ewan Harris |
| Created | 2019-03-07T11:49:14.000+0000 |
| Updated | 2019-06-19T22:30:25.000+0000 |
Description
Update Appcelerator Alloy to use new BackboneJS version 1.4.0
For reference, previous PRs and ticket for 1.3.0 https://github.com/appcelerator/alloy/pull/868 https://github.com/appcelerator/alloy/pull/870 ALOY-1534. Note that any underscore requires must be adapted for the alloy path.
Thanks for the ticket [~ahmed.mohamed20320]! I think like previous versions, we'll include backbone@1.4.0 in the distribution but not make it the default version. What do you think [~topener]? Maybe we could update the template config.json to point to a newer version?
This would be nice because of a lot of major changes in 1.3.3 and later.
I feel adding it as an option in config is great, like how it is done now too. In the long term we should look into making it default though, maybe for 9.0
We should also evaluate updating to underscore 1.9.1 (currently 1.8.3) when we do this
PR: https://github.com/appcelerator/alloy/pull/929
Tested with cli 7.1.0-master.22.BackboneJS v1.4.0 and upgraded UnderscoreJS 1.9.1 is included. Also did quick check with kitchen sink v2 and works as expected.closing *Test Environment:*
Name = Mac OS X Version = 10.13.6 Architecture = 64bit Node.js Node.js Version = 10.13.0 npm Version = 6.4.1 Titanium CLI CLI Version = 5.2.1 Titanium SDK SDK Version = 8.2.0.v20190619100154 Cli =7.1.0 master 22 Device -Samsung 5s android 6 ,iPhone 6s plus iOS 12