[ALOY-1743] Runtime error when Widget contains another Widget at the top level

GitHub Issue	n/a
Type	Bug
Priority	None
Status	Resolved
Resolution	Unresolved
Affected Version/s	CLI Release 8.1.1, Alloy 1.15.2
Fix Version/s	Alloy 1.15.3, CLI Release 9.0.0
Components	n/a
Labels	regression
Reporter	Ewan Harris
Assignee	Ewan Harris
Created	2020-11-18T12:06:09.000+0000
Updated	2021-06-16T14:13:33.000+0000

Description

In the attached sample a Widget is used alongside another View in a Widget, this causes a runtime error when trying to access properties from the included Widget, this is most like down to the the changes in the two linked tickets where the symbol definition for included Widgets has changed

Attachments

File	Date	Size
sampleTest.zip	2020-11-18T14:53:45.000+0000	8717675

Comments

Ewan Harris 2020-11-18

PR: https://github.com/appcelerator/alloy/pull/1035 I've tested the following: * Test cases associated with ALOY-1256 and ALOY-1738 * https://github.com/ewanharris/alloy-widget-test which is the same as in ALOY-1256 but includes children in the Widget tag * The sample attached here To patch this in the appc CLI: 1. Open up the appc CLI directory in explorer/finder * Windows: C:\Users\\.appcelerator\install\8.1.1\package\ * MacOS: ~/.appcelerator/install/8.1.1/package/ 2. Open node_modules/alloy/Alloy/commands/compile/parsers/Alloy.Require.js 3. Apply the changes in the above PR
Ewan Harris 2020-11-18

alloy-devkit PR: https://github.com/appcelerator/alloy-devkit/pull/194
Samir Mohammed 2020-12-10

FR Passed, Runtime error is no longer shown when tested with the test case mentioned in the description. Tested using CLI Version 8.1.2-27.

JSON Source