[ALOY-183] Change getUIRoot() to getView()
GitHub Issue | n/a |
---|---|
Type | Improvement |
Priority | High |
Status | Resolved |
Resolution | Fixed |
Resolution Date | 2012-08-16T08:42:31.000+0000 |
Affected Version/s | 2012 Sprint 17 |
Fix Version/s | 2012 Sprint 17, Release 3.0.0 |
Components | Runtime, XML |
Labels | n/a |
Reporter | Tony Lukasavage |
Assignee | Unknown |
Created | 2012-08-15T14:51:08.000+0000 |
Updated | 2018-03-07T22:26:03.000+0000 |
Description
To simplify the naming of functions, let's make the following changes:
*
getView(id)
--> stays the same, returns underlying view by id
* getUIRoot()
--> getView()
(no parameters)
* getUIRoots()
--> getViews()
Arthur says the getView(), getViews(), getView(id) seem clear and gives the go ahead
Feedback FTW
In retrospect,
getUIRoot()
andgetUIRoots()
should stay as they represent an array of all top-level views, which is different from getView(), which has access to all views, not just top-level. The interface for these interactions should be like this: * *getView(id)* - Return any view contained in the controller by id. If no id is given, return the first top-level view (just like getUIRoot). * *getUIRoot* - Return the first top-level view. * *getUIRoots* - Return an array of all top-level viewsFinal interface: * *getView(id)* - Return any view contained in the controller by id. If no id is given, return the first top-level view. * *getViews()* - Return an object containing all views from the view hierarchy, keyed by their id. * *getTopLevelViews()* - Return an array of all top-level views