Titanium JIRA Archive
Alloy (ALOY)

[ALOY-265] Improve Ti.UI.Picker parser effeciency

GitHub Issuen/a
TypeStory
PriorityLow
StatusClosed
ResolutionFixed
Resolution Date2014-08-06T19:38:33.000+0000
Affected Version/s2012 Sprint 19
Fix Version/sAlloy 1.3.0, 2013 Sprint 23
ComponentsXML
Labelsqe-manualtest
ReporterTony Lukasavage
AssigneeTony Lukasavage
Created2012-09-13T10:42:23.000+0000
Updated2014-08-06T19:38:33.000+0000

Description

Due to a bug in the way Android handles PickerColumn arrays (TIMOB-10895) we need to implement a slightly less-than-optimal way of adding picker columns to pickers. Instead of composing an array of PickerColumns and then adding the array to the Picker, we need to add each PickerColumn individually to the Picker. Not a big deal, just requires a less-than-optimal solution til this is fixed.

Comments

  1. Tony Lukasavage 2013-11-09

    This PR took longer than expected because it addressed ALOY-266 as well. PR: https://github.com/appcelerator/alloy/pull/273 test app: https://github.com/appcelerator/alloy/tree/master/test/apps/ui/picker Functional test should be performed on Android and iOS.

    Run the app

    Assert that there are no compile time or runtime errors.

    Assert that the first tab "single column" has items, including the "required" final item.

    Assert that tab 2 "multi-column" has columns and items. The first column includes a required item at the end. The 2nd column includes a required item at the beginning. The entire 3rd column itself is required.

    All should render and run without error.

  2. Federico Casali 2013-12-03

    Verified fixed and working as expected. TiSDK 3.2.0.v20131127194046 Alloy 1.3.0-beta CLI 3.2.0-beta Closing.

JSON Source