[ALOY-457] Make Alloy sync adapter sync() function signature match that of Backbone
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | High |
Status | Resolved |
Resolution | Fixed |
Resolution Date | 2013-01-23T16:46:07.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Alloy 1.0.0, 2013 Sprint 02 |
Components | Runtime |
Labels | n/a |
Reporter | Tony Lukasavage |
Assignee | Unknown |
Created | 2013-01-14T11:26:58.000+0000 |
Updated | 2018-03-07T22:26:14.000+0000 |
Description
Right now the sync function for custom sync adapters is as follows:
function Sync(model, method, opts) {
// ...
}
but as David Yang points out in this PR: https://github.com/appcelerator/alloy/pull/86
The order should be (method, model, opts):
function Sync(method, model, opts) {
// ...
}
We need to change the order these are processed in the runtime alloy.js file, as well as in all Alloy's supported sync adapters. In addition, we will need to communicate this change to the community as it will break existing sync adapters. As this is a breaking change, it will need to go in before the 1.0.0 release of Alloy.
No comments