[ALOY-536] Update uglifyjs to version 2.0
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | High |
| Status | Resolved |
| Resolution | Fixed |
| Resolution Date | 2013-03-01T22:19:43.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Alloy 1.1.0, 2013 Sprint 05 |
| Components | XML |
| Labels | n/a |
| Reporter | Tony Lukasavage |
| Assignee | Unknown |
| Created | 2013-02-25T18:50:30.000+0000 |
| Updated | 2018-03-07T22:26:04.000+0000 |
Description
In order to leverage source mapping capabilities, we need to update uglifyjs from version 1.3.0 to version 2.0 where this functionality was introduced. This will require modifying all the AST parsing sections of Alloy and then a lot of testing to assert that the new parsing is working correctly.
uglify-js v1 has been completed removed from alloy. Alloy is now using uglify-js 2.2.5 for all AST operations. There are a few lingering issues in terms of getting better compression from uglify-js v1 versus v2, which has resulted in some of the optimization unit tests failing. The failures, though, will not crash apps or generate invalid JS. they just signify non-optimal compression. This is covered in ALOY-540. These changes are in the "uglify2" branch and will not be merged until ALOY-540 has been resolved.
Updated version of uglify-js is 2.2.5. For further testing on this bug, please provide more details
[~amittal] what are you talking about? I logged and resolved this improvement months ago myself. Your comment doesn't really make any sense.