[ALOY-687] Pre-process all platform queries in runtime styles
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | High |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2013-06-04T23:05:11.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Alloy 1.2.0, 2013 Sprint 12 |
| Components | Runtime, Styling |
| Labels | qe-testadded |
| Reporter | Tony Lukasavage |
| Assignee | Tony Lukasavage |
| Created | 2013-06-04T21:33:01.000+0000 |
| Updated | 2013-08-02T02:07:44.000+0000 |
Description
Currently when processing style queries at runtime the platform conditions are still present. The runtime style modules should not even include style entries in the style array that does not apply to the current platform. These entries should be eliminated before ever reaching the runtime to ensure the best possible runtime processing performance.
This took a little longer as I additionally optimized the runtime style by completely removing any platform queries from the "queries" key. PR: https://github.com/appcelerator/alloy/pull/144 Test app: https://github.com/appcelerator/alloy/tree/master/test/apps/testing/ALOY-687 Follow the in-app instructions for functionally passing the test, ideally on all supported platforms.
Verfied working as expected. Titanium SDK 3.1.2.v20130730133101 Alloy 1.2.0-alpha2 Appcelerator Studio 3.1.2.201307261628 CLI 3.1.1 Node 0.8.22 Closing.