[ALOY-898] com.appcelerator.loading widget causes memory leak
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Critical |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2013-12-06T17:34:48.000+0000 |
| Affected Version/s | Alloy 1.3.0 |
| Fix Version/s | 2013 Sprint 25 |
| Components | Widgets |
| Labels | qe-closed-3.3.0 |
| Reporter | Tony Lukasavage |
| Assignee | Tony Lukasavage |
| Created | 2013-12-06T17:09:57.000+0000 |
| Updated | 2014-06-20T07:45:33.000+0000 |
Description
Details of the issue are in ALOY-897.
This ticket is meant to resolve the direct impact of ALOY-897 on the com.appcelerator.loading widget until ALOY-897 is resolved.
Attachments
| File | Date | Size |
|---|---|---|
| Screen Shot 2013-12-06 at 12.18.02 PM.png | 2013-12-06T17:35:30.000+0000 | 128012 |
| Screen Shot 2013-12-06 at 12.27.04 PM.png | 2013-12-06T17:35:09.000+0000 | 127749 |
PR: https://github.com/appcelerator/alloy/pull/284 test app: https://github.com/appcelerator/alloy/tree/master/test/apps/testing/ALOY-898 Updated on master and 1_3_X.
functional test
Run the app on ios
Open up Instruments and test the app for allocations. Details here: https://wiki.appcelerator.org/display/td/10+-+Finding+and+correcting+memory+leaks
Repeatedly open and close the window in the app.
You should see that the "living" entries are gradually being cleared and that the "transient" entries are increasing, meaning that the memory is no longer being leaked. Look at the second attached screenshot to see what it should look like.
Prior to this fix, the "living" entires would stay forever showing a memory leak. Look at the first attached screenshot to see what this should look like for comparison.Verified FIXED using : Mac :10.9.3 Appcelerator Studio, build: 3.3.0.201406171619 SDK 3.3.0.v20140617161713 acs-1.0.15 alloy@1.4.0-rc npm-1.3.2 titanium@3.3.0-rc titanium-code-processor-1.1.1 No memory leaks found after running attached app. Hence closing as FIXED.