[ALOY-914] Default Alloy Project shows incorrect appicon
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2014-11-26T22:41:18.000+0000 |
Affected Version/s | Alloy 1.3.0 |
Fix Version/s | Alloy 1.4.0, Alloy 1.3.1, 2014 Sprint 03 |
Components | Titanium SDK |
Labels | qe-3.2.0, qe-manualtest, regression |
Reporter | Priya Agarwal |
Assignee | Tony Lukasavage |
Created | 2013-12-24T10:01:16.000+0000 |
Updated | 2014-11-26T22:41:18.000+0000 |
Description
Steps to reproduce:
1)Create any default alloy project and install on device.
Expected Result:
Alloy app icon must be displayed on the device.
Actual Result:
Instead of Alloy app icon classic app icon is being displayed on device.
Tried with current alloy release version alloy@1.3.0,getting the incorrect app icon for alloy project when installing on device.
But by changing Studio
using Studio:3.1.4.201310152044 correct alloy app icon is being displayed on device.
Priya, when you tried Studio 3.1.4, which versions of CLI and SDK were you using?
Used Sdk:3.2.0.GA and CLI 3.2.0
Priya, please check this using an all 3.1.4 configuration (3.1.4 sdk and ide + 1.3.1 alloy) when you can
Have checked with configuration: Appc-Studio: 3.1.4.201310152044 Sdk:3.1.3.GA acs:1.0.11 alloy:1.3.1-alpha npm:1.3.2 titanium:3.1.2 titanium-code-processor:1.0.3 Osx: Mountain Lion 10.8.5 Am still getting the incorrect app icon for alloy project.
I could not get the correct icon either in older versions such as 3.1.3.GA. I downgraded alloy, CLI, and SDK. Here's what I found: If you import a sample from studio, the icons are correct for the alloy samples. After talking with the studio team, it looks like for samples.. studio will manually copy over the sample, including the icons. For template studio will do something like:
I'm not sure if alloy is supposed to copy the alloy app icon over during the new command, but the current behavior is that it doesn't. The only real reference I see to the alloy app icon is at https://github.com/appcelerator/alloy/blob/58e4553ac86e48a62e395cb05b52afdb066171b6/Alloy/commands/info/index.js and I'm not sure how this is used during project creation. [~tlukasavage], Could you take a look at this and provide some guidance?
PRs: master: https://github.com/appcelerator/alloy/pull/290 1_3_X: https://github.com/appcelerator/alloy/pull/289
Verified fixed. Icon displayed is the Alloy App Icon. TiSDK 3.2.1.v20140106195644 Appcelerator Studio 3.2.1.201401061716 Alloy 1.3.1-beta2 Android Google Nexus Galaxy 4.3 iPhone 5 iOS7 Closing.
Reopening the issue as we encounter again with the bug with environment: Appcelerator Studio, build: 3.2.1.201402051410 SDK build: 3.2.1.v20140205094854 acs@1.0.12 alloy@1.3.1-cr2 npm@1.3.2 titanium@3.2.1-beta3 titanium-code-processor@1.1.0 OS:Ubuntu(12.04),Windows(8)
[~pagarwal] what platform are you targeting? What device? Does this apply to sim/emulator too?
Alloy: 1.3.1-cr2 CLI: 3.2.1-beta3 SDK: 3.2.1.v20140205094854 Tested with CLI: 1)
ti create --platforms android,ios -n ALOY914 --id com.appcelerator.alloy914
2) in alloy914 directory,alloy new .
3)ti build --platform ios
-- got the Alloy icon 4)ti build --platform android --target device
-- installed to Galaxy Nexus (4.2.2) -- got the Alloy icon Tested with Appcelerator Studio 3.3.0.201402031746 1) Create a new project in Studio 2) Run on Device (Galaxy Nexus) -- got the Alloy icon My version of Studio is ahead of the tested version. Sorry, it's what the preview site said was available as an upgrade for me.New test, same Alloy & CLI environment as before 1) Uninstalled Studio 3.3.x and installed Appcelerator Studio 3.2.1.201402051410 2) Removed app from Galaxy Nexus 3) Cleaned project in Studio 4) Built & installed to Galaxy Nexus. I get the Alloy app icon 5) Built & installed to iPhone simulator. I get the Alloy app icon
Cannot reproduce using latest reported failing configuration as well as others tested.
We were not able to reproduce this issue in the following environment: Appcelerator Studio, build: 3.2.1.201402051410 SDK build: 3.2.1.v20140205094854 CLI: 3.2.1-beta3 Alloy: 1.3.1-cr2 Xcode: 5.0.2 OS: Mavericks (10.9.1), Mountain Lion (10.8.5), Windows 8, Ubuntu 12.0.4 Devices: iphone 5c (7.0.4), Nexus 5 (4.4.2), Nexus Galaxy Note 2 (4.1.2), Sony Xperia (4.1.2) *However,* we were able to reproduce this issue with current 3.2.1 stack plus Windows 8.1 with Droid 3 (2.3.4), Samsung Galaxy S3 (4.0.4), Sony Xperia (4.1.2), and Nexus 5 (4.4).
Reopening due to failure on Windows 8.1
I have no way to test this to verify. I don't have a Windows system.
Cannot reproduce the issue from the command line using: * Windows 8.1 * Android 4.4.2 + Galaxy Nexus emulator * TiSDK 3.2.1.v20140205094854 * CLI 3.2.1-beta3 * Alloy 1.3.1-cr2
I will try again using Appcelerator Studio and its templates to see if those are the true source of the issue.
Still can't reproduce with the setup of the prior comment, and including Appcelerator Studio 3.2.1.201402061120, while following the exact steps noted in the original description. App icons, splash screens, etc... are all the ones you would expect for Alloy.
master: https://github.com/appcelerator/alloy/pull/334 1_3_X: https://github.com/appcelerator/alloy/pull/333 functional testing instructions are noted in the description.
fixes confirmed
Verified the fixed. With Environment: Appc Studio:3.2.1.201402061120 Sdk:3.2.1.v20140206170116 alloy:1.3.1-cr3 titanium:3.2.1-beta4 acs:1.0.12 titanium-code-processor:1.1.0 Osx: Windows,Ubuntu Device: Nexu4(v4.1.1) Could see the alloy icon on both emulator and device.Hence closing the issue.
Verified fixed on Mac(10.9) Maverick also. With environment: Appc Studio:3.2.1.201402061120 Sdk:3.2.1.v20140206170116 alloy:1.3.1-cr3 titanium:3.2.1-beta4 acs:1.0.12 titanium-code-processor:1.1.0 Osx: Maverick 10.9 Device: Nexu4(v4.1.1) Working fine