[ALOY-991] Support new ActionBar subtitle property in <Menu>
GitHub Issue | n/a |
---|---|
Type | New Feature |
Priority | High |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2014-05-08T14:11:14.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Alloy 1.4.0 |
Components | XML |
Labels | qe-testadded |
Reporter | Benjamin Hatfield |
Assignee | Feon Sua Xin Miao |
Created | 2014-04-23T21:24:39.000+0000 |
Updated | 2014-06-22T13:21:07.000+0000 |
Description
TiSDK Release 3.2.3, introduces a new ActionBar property called subtitle to set the subtitle of the ActionBar: http://docs.appcelerator.com/titanium/latest/#!/api/Titanium.Android.ActionBar-property-subtitle
Since Alloy XML for Release 1.4.0 will support ActionBar properties in the Menu element, this property should be added as an attribute.
Example:
<Alloy>
<Window title="My Test App">
<Menu platform="android" title="My XML Menu" subtitle="Foobaz" />
<Label>Hello, World</Label>
</Window>
</Alloy>
Update to new PR. Old PR: https://github.com/appcelerator/alloy/pull/388 New PR: https://github.com/appcelerator/alloy/pull/390 Test app: https://github.com/feons/alloy/tree/ALOY-991/test/apps/testing/ALOY-991 Functional Test: "subtitle" is a valid attribute for Menu element, the string value appears below the title string.
Pull request passes code review and all tests. Merged.
Verified working as expected. TiSDK 3.3.0.v20140508223312 Alloy 1.4.0-dev Appcelerator Studio 3.3.0.201405011408 CLI 3.3.0-dev Closing.