[ALOY-1004] Styles priority is not correctly respected when using Custom TSS queries
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Critical |
| Status | Resolved |
| Resolution | Fixed |
| Resolution Date | 2014-05-07T15:55:07.000+0000 |
| Affected Version/s | Alloy 1.4.0 |
| Fix Version/s | n/a |
| Components | Styling |
| Labels | qe-3.3.0 |
| Reporter | Federico Casali |
| Assignee | Tim Poulsen |
| Created | 2014-05-06T00:35:04.000+0000 |
| Updated | 2014-06-18T22:33:47.000+0000 |
I discussed priorities with a group of the Titans prior to implementing this feature. It was universally agreed that custom TSS conditions should have the highest priority and take precedence over any other conditionals. If you look to where priorities are defined in Alloy/commands/compile/styler.js (line 19), you'll see that TSSIF conditionals are assigned the highest priority. Your example shows that this is the priority hierarchy that is being applied. I'm open to changing this if our internal decision is that priorities should be assigned differently. However, for now I'm closing this as invalid because it's working as intended.
Reopening after speaking with Federico. Component selectors shouldn't override ID selectors regardless of whether custom TSS queries are in the mix or not.
Further sample with Custom TSS applied to the Controller API : https://github.com/federico1525/Alloy-Samples/tree/master/ALOY-1004
PR: https://github.com/appcelerator/alloy/pull/387 Includes a test app, which is an expanded version of the one posted by Federico in the preceding comment
PR merged