Titanium

[ALOY-1108] Some .svn directories slipped into the GIT repo of Alloy

GitHub Issuen/a
TypeBug
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2014-08-25T19:17:43.000+0000
Affected Version/sAlloy 1.4.1
Fix Version/sAlloy 1.5.0
ComponentsSamples & Templates
LabelsTCSupport, alloy, qe-manualtest, svn
ReporterWouter Monkhorst
AssigneeTim Poulsen
Created2014-07-25T08:41:28.000+0000
Updated2014-08-27T17:29:19.000+0000

Description

Dear Alloy guru's, I found some .svn folders in the GIT repo that break an SVN checkout. It's minor I know, but just to let you know. Thanks, Wouter Monkhorst

Attachments

FileDateSize
svn_folders_found.txt2014-07-25T08:41:28.000+0000800
svnLocations.png2014-08-25T18:42:12.000+000018954

Comments

  1. Mauro Parra-Miranda 2014-08-04 Thanks for the report! Tony, the original reporter is: [~monkhorst] (Wouter Monkhorst). Do you mind to switch the reporter to him? (I can't change it to the original reporter when moving from TC to ALLOY). Best Regards
  2. Tim Poulsen 2014-08-11 Thanks. Of the .svn folders you found, the ones for ALOY-839 need to remain. That test app was in response to the ticket noting that the .svn folders were being copied to the Resources directory incorrectly. We can certainly remove the others.
  3. Tim Poulsen 2014-08-18 PR: https://github.com/appcelerator/alloy/pull/509 Functional test: At an OS X terminal, within your local Alloy repo folder, enter this command: find . -type d -name '.svn' The only files found should be the .svn folders within the ALOY\-839 test app. As noted above, those need to remain for the tests associated with that ticket.
  4. Feon Sua Xin Miao 2014-08-19 **APPROVED**
  5. Feon Sua Xin Miao 2014-08-19 PR merged
  6. Ewan Harris 2014-08-25 Ran the command in my local Alloy repo folder. It returned the expected locations and showed one more .svn file in ALOY-488/widgets/starrating. See attached screenshot for confirmation. Reopening ticket.
  7. Tim Poulsen 2014-08-25 New PRs: https://github.com/appcelerator/alloy/pull/523 (1_5_X) https://github.com/appcelerator/alloy/pull/524 (master) [~fmiao] would you review & merge those PRs?
  8. Feon Sua Xin Miao 2014-08-26 approved & merged.
  9. Ewan Harris 2014-08-27 Verified fix on: Mac OSX 10.9.4 Appcelerator Studio, build: 3.4.0.201408270900 Titanium SDK build: 3.4.0.v20140826143313 Titanium CLI, build: 3.4.0-dev Alloy: 1.5.0-dev Ran the command while in my local Alloy repo, only the expected .svn files in the ALOY-839 were returned. Closing ticket

JSON Source