Titanium

[ALOY-1113] Fix case on 'alloy info adapters' command output

GitHub Issuen/a
TypeBug
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2014-10-23T20:44:10.000+0000
Affected Version/sn/a
Fix Version/sAlloy 1.6.0, Alloy 1.7.0
ComponentsSamples & Templates
Labelsn/a
ReporterPraveen Innamuri
AssigneeTim Poulsen
Created2014-08-08T21:10:35.000+0000
Updated2015-01-13T14:43:07.000+0000

Description

"alloy info adapters" command returns the contents of description in the tag name "description". However, "alloy info samples" (or even templates) have the contents in "Description" tag/field. Studio is expecting the same tag for all samples, templates and adapters. I believe the tag name has to be "Description" for all commands.

Comments

  1. Tim Poulsen 2014-08-11 [~pinnamuri] The JSON objects returned differ in other ways, too. alloy info adapters returns an array of objects with description and platforms properties alloy info samples and alloy info templates returns an array of objects with name, label, Description, and icon properties Does the objects returned by all three commands need to match exactly?
  2. Praveen Innamuri 2014-08-11 I'm fine with all different fields returned by those various commands. The only concern that I raised here is samples/templates return the description contents through 'Description' tag. However, adapters output return the description contents through 'description' tag. There is a discrepancy in the tag names. Studio assumes all description content through 'Description' tag, and currently it fails to read the description of adapters. For the sake of consistency, it might to be better to have same tag names from Alloy.
  3. Tim Poulsen 2014-08-19 PR: https://github.com/appcelerator/alloy/pull/511 Functional review: 1. Run alloy info adapters command. The output returns an array of objects with Description and platforms properties 2. Run jake test:spec\[info.js\] and all tests should pass.
  4. Feon Sua Xin Miao 2014-08-20 PR merged
  5. Feon Sua Xin Miao 2014-08-20 **APPROVED**
  6. Tim Poulsen 2014-10-23 Mistakenly reopened
  7. Feon Sua Xin Miao 2015-01-13 Backport 1_6_X : https://github.com/appcelerator/alloy/pull/653

JSON Source