[ALOY-1116] sql sync adapter: optimize update method for adding/updating models

GitHub Issuen/a
Resolution Date2014-09-17T15:28:57.000+0000
Affected Version/sn/a
Fix Version/sAlloy 1.7.0
ReporterTim Poulsen
AssigneeTim Poulsen


Community PR: https://github.com/appcelerator/alloy/pull/518 The proposed change should offer speed improvements but implements no functional changes (in other words, existing code should continue to work). Per the comment on the PR: Consider adding a batch update method that would be faster because it would process all model changes in a single SQL statement rather than by opening repeated connections to the database. (Likely that's a separate ticket)


  1. Tim Poulsen 2014-09-11 Tested the PR. Small typo (see comment on PR) but other than that it works and passes all tests. I see no obvious side-effects and I'm ready to merge, pending a fix for the typo.
  2. Tim Poulsen 2014-09-12 PR: https://github.com/appcelerator/alloy/pull/556 Functional test: any of the test/apps/models/* sample apps should run without error.
  3. Feon Sua Xin Miao 2014-09-15 PR merged.
  4. Tim Poulsen 2014-09-15 PR to back out the change https://github.com/appcelerator/alloy/pull/562 The immediately-invoked function is necessary to permit garbage collection
  5. Tim Poulsen 2014-09-16 New PR https://github.com/appcelerator/alloy/pull/564 This change restores the self-calling (IIFE) function, removes the unnecessary transaction, and implements the lastInsertId as in the original community PR. Please merge pull 562 before merging this one.
  6. Feon Sua Xin Miao 2014-09-17 PR merged.

JSON Source