[ALOY-1122] Consistent naming for platform-specific folders
| GitHub Issue | n/a |
|---|
| Type | Improvement |
|---|
| Priority | High |
|---|
| Status | Closed |
|---|
| Resolution | Fixed |
|---|
| Resolution Date | 2014-09-04T17:13:16.000+0000 |
|---|
| Affected Version/s | n/a |
|---|
| Fix Version/s | Alloy 1.5.0 |
|---|
| Components | Tooling |
|---|
| Labels | qe-manualtest |
|---|
| Reporter | Benjamin Hatfield |
|---|
| Assignee | Tim Poulsen |
|---|
| Created | 2014-08-27T21:11:17.000+0000 |
|---|
| Updated | 2014-09-05T23:07:35.000+0000 |
|---|
Description
There is a discrepancy in the naming of the folder for iOS-specific resources in the Alloy file structure.
For assets and libs, the folder is called "iphone".
For controllers, views, and styles, the folder is called "ios".
I think we should have one consistent folder name for Alloy.
Attachments
Added sample project. Running the project as-is, the iOS-specific view, asset and lib files are not used. To use the iOS-specific resources, copy the image from the app/assets/ios folder to the app/assets/iphone folder, rename app/views/iphone to app/views/ios and rename app/lib/ios to app/lib/iphone.
[~fmiao] Can you take a look at this? If not, I will tomorrow.
Possibly caused by changes from ALOY-963
Not caused by ALOY-963. This same behavior is observed in Alloy 1.3.1 and 1.4.x, per tests by me and Feon.
PRs * https://github.com/appcelerator/alloy/pull/534 (master) * https://github.com/appcelerator/alloy/pull/535 (1_5_X) Functional test Use the included ALOY\-1122 test app. Run for iOS. Click the label, the resulting alert should output the message the sum of 1+2 is 3. The graphic at the bottom of the screen should be an Appcelerator logo. Repeat for Android. Note that for iOS, the lib being included is lib/ios/util.js not lib/iphone/util (as that version would return "the sum of 1+2 is error") and that the asset includes is assets/iphone/appcelerator.png (correct logo) not assets/ios/appcelerator.png (which is a bug graphic)
Original PRs didn't work for Android or MobileWeb as expected. New PR for master: https://github.com/appcelerator/alloy/pull/541 Updated PR for 1_5_X: https://github.com/appcelerator/alloy/pull/535 Same functional test except that the alert on Android says 1+2 = android so that you're sure you're getting the lib/android/util.js file and not the one from the main directory or ios subdirectory.
*APPROVED*
PR merged.