Titanium

[ALOY-1122] Consistent naming for platform-specific folders

GitHub Issuen/a
TypeImprovement
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2014-09-04T17:13:16.000+0000
Affected Version/sn/a
Fix Version/sAlloy 1.5.0
ComponentsTooling
Labelsqe-manualtest
ReporterBenjamin Hatfield
AssigneeTim Poulsen
Created2014-08-27T21:11:17.000+0000
Updated2014-09-05T23:07:35.000+0000

Description

There is a discrepancy in the naming of the folder for iOS-specific resources in the Alloy file structure. For assets and libs, the folder is called "iphone". For controllers, views, and styles, the folder is called "ios". I think we should have one consistent folder name for Alloy.

Attachments

FileDateSize
AlloySandbox.zip2014-08-27T21:42:12.000+00004207140

Comments

  1. Benjamin Hatfield 2014-08-27 Added sample project. Running the project as-is, the iOS-specific view, asset and lib files are not used. To use the iOS-specific resources, copy the image from the app/assets/ios folder to the app/assets/iphone folder, rename app/views/iphone to app/views/ios and rename app/lib/ios to app/lib/iphone.
  2. Tim Poulsen 2014-08-27 [~fmiao] Can you take a look at this? If not, I will tomorrow.
  3. Tim Poulsen 2014-08-28 Possibly caused by changes from ALOY-963
  4. Tim Poulsen 2014-08-28 Not caused by ALOY-963. This same behavior is observed in Alloy 1.3.1 and 1.4.x, per tests by me and Feon.
  5. Tim Poulsen 2014-09-02 PRs * https://github.com/appcelerator/alloy/pull/534 (master) * https://github.com/appcelerator/alloy/pull/535 (1_5_X) Functional test Use the included ALOY\-1122 test app. Run for iOS. Click the label, the resulting alert should output the message the sum of 1+2 is 3. The graphic at the bottom of the screen should be an Appcelerator logo. Repeat for Android. Note that for iOS, the lib being included is lib/ios/util.js not lib/iphone/util (as that version would return "the sum of 1+2 is error") and that the asset includes is assets/iphone/appcelerator.png (correct logo) not assets/ios/appcelerator.png (which is a bug graphic)
  6. Tim Poulsen 2014-09-04 Original PRs didn't work for Android or MobileWeb as expected. New PR for master: https://github.com/appcelerator/alloy/pull/541 Updated PR for 1_5_X: https://github.com/appcelerator/alloy/pull/535 Same functional test except that the alert on Android says 1+2 = android so that you're sure you're getting the lib/android/util.js file and not the one from the main directory or ios subdirectory.
  7. Feon Sua Xin Miao 2014-09-04 *APPROVED*
  8. Feon Sua Xin Miao 2014-09-04 PR merged.
  9. Federico Casali 2014-09-05

JSON Source