Titanium JIRA Archive
Alloy (ALOY)

[ALOY-1159] Update underscore library to latest version

GitHub Issuen/a
TypeImprovement
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2014-10-28T00:54:50.000+0000
Affected Version/sn/a
Fix Version/sAlloy 1.6.0
ComponentsBuiltins
Labelsn/a
ReporterTim Poulsen
AssigneeTim Poulsen
Created2014-10-10T13:09:27.000+0000
Updated2015-03-30T21:05:20.000+0000

Description

Update underscore lib, per PR https://github.com/appcelerator/alloy/pull/578 Need to update both runtime and build-time versions of the lib.

Comments

  1. Tim Poulsen 2014-10-14

    In my testing, switching to Underscore 1.7.0 causes many of our tests to fail. This is possibly due to changes in the way the _.template function operates, though my workarounds for that didn't make tests work. Version 1.6.0 seems to work just fine. Possible options: * Switch to 1.7.0 and fix the underlying issues * Switch to 1.6.0 for the near-term, resolve 1.7.0 issues later * Switch to the lodash library instead
  2. Tim Poulsen 2014-10-15

    New PR https://github.com/appcelerator/alloy/pull/589 from [~elbow]
  3. Tim Poulsen 2014-10-15

    PR merged. Thanks [~elbow]! Functional test: Use the test/apps/models/todo app for testing, as models & collections rely on Backbone, which relies on Underscore. 1. Edit test/apps/models/todo/models/todo.js and un-comment the "for Backbone 1.1.2" block of code 2. Run that app. Add two to-do items. Mark one as done. Switch to the Active and Done tabs; the correct items should be shown on each page. Switch back to the All tab and both items should be listed.
  4. Tim Poulsen 2014-10-23

    Reopen to backport to 1_6_X branch
  5. Tim Poulsen 2014-10-24

    PR for 1_6_X https://github.com/appcelerator/alloy/pull/609 Functional test as above
  6. Feon Sua Xin Miao 2014-10-28

    PR merged.
  7. Eric Wieber 2015-03-30

    Verified fixed using: Titanium SDK 4.0.0.v20150325201813 Studio 4.0.0.201503271912 Appc NPM: 0.3.37 Appc CLI 0.2.204 Alloy 1.6.0-alpha2 Files have been updated to 1.6.0 and test cases listed above behave as expected.

JSON Source