[ALOY-1167] Update travis.yml to exit w/non-zero value on errors
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | High |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2014-10-28T02:31:50.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Alloy 1.6.0 |
| Components | Tooling |
| Labels | n/a |
| Reporter | Tim Poulsen |
| Assignee | Tim Poulsen |
| Created | 2014-10-15T16:56:16.000+0000 |
| Updated | 2015-03-26T16:13:13.000+0000 |
Description
GitHub builds are marked as passing even when errors are encountered by Travis. Our test scripts must be exiting with a non-zero value in the case of errors.
We should add an
after_script section that exits with 0/non-zero to properly signal build state.
http://docs.travis-ci.com/user/build-configuration/
PR https://github.com/appcelerator/alloy/pull/595 I'm not sure how you can test this, as this change is entirely for the Travis environment on our GitHub repo. Perhaps simply checking the travis build log (click the "Details" link) on the pull request page is the only way to test it. You should see that all tests pass, no failures are reported, and ultimately the build is marked as passing. Prior to this change, even when individual tests failed, the overall PR would be marked as passing.
PR merged.
Reopen for 1_6_X backport
PR https://github.com/appcelerator/alloy/pull/610
PR merged.
Verified fixed using: Alloy 1.6.0-alpha Successful tests exit with zero while tests with errors exit with non-zero values.