Titanium

[ALOY-1198] Update ui/android_menu text for Honeycomb/action bar usage

GitHub Issuen/a
TypeImprovement
PriorityLow
StatusOpen
ResolutionUnresolved
Affected Version/sn/a
Fix Version/sn/a
ComponentsSamples & Templates
Labelsn/a
ReporterTim Statler
AssigneeTim Poulsen
Created2014-12-10T03:52:15.000+0000
Updated2014-12-10T18:42:08.000+0000

Description

The comments in the ui/android_menu test app should better reflect the current usage of and to add action bar items, not to create a menu. The comment in index.xml says <!-- This will add an Android menu -->. Ideally, it would say something like:
		<!-- On Android 3.0 devices and later, this will add items to the action bar. 
			 On older Android devices with a physical menu button, it will add items to the
			 menu that appears when the menu button is pressed.   -->
The Label in index.xml says "Press the menu button", but new Android devices don't have a menu button. Ideally, the sample would conditionally display this button based on the API level of the device.

Comments

  1. Tim Statler 2014-12-10 PR https://github.com/appcelerator/alloy/pull/629

JSON Source