Titanium

[ALOY-1205] Alloy launch image for 667h has the wrong filename

GitHub Issuen/a
TypeBug
PriorityCritical
StatusClosed
ResolutionFixed
Resolution Date2015-04-10T06:48:10.000+0000
Affected Version/sAlloy 1.5.1
Fix Version/sAlloy 1.6.0, Alloy 1.7.0
ComponentsSamples & Templates
Labelslaunchimages, splash
ReporterFokke Zandbergen
AssigneeTim Poulsen
Created2014-12-17T16:08:17.000+0000
Updated2015-04-16T23:40:51.000+0000

Description

It is named Default-Portrait-667h@2x.png but should be Default-667h@2x.png like the classic template has: https://github.com/appcelerator/titanium_mobile/tree/master/iphone/templates/app/default/template/Resources/iphone PR: https://github.com/appcelerator/alloy/pull/637

Comments

  1. Tim Poulsen 2014-12-17 PR merged and cherry-picked to 1_6_X
  2. Eric Wieber 2015-03-25 Default-Portrait-667h@2x.png still exists in the 1_6_X branch. Reopening. Can the incorrect image be removed or the labels be updated to reflect that the fix is only fully in master, currently?
  3. Feon Sua Xin Miao 2015-03-30 1_6_X: https://github.com/appcelerator/alloy/pull/674
  4. Ingo Muschenetz 2015-04-10 [~fokkezb] can you review and merge this if it looks correct?
  5. Fokke Zandbergen 2015-04-10 APPROVED (but I can't merge on Alloy)
  6. Feon Sua Xin Miao 2015-04-10 Merged.
  7. Ewan Harris 2015-04-16 Verified using: Mac OSX 10.10.2 Titanium SDK build: 4.0.0.v20150415182612 Appc CLI (NPM): 0.3.44 Appc CLI (Registry): 0.2.249 When creating a new alloy app as of 0.2.249 the filename is now Default-667h@2x.png. Closing ticket

JSON Source