[ALOY-1264] Support New iOS SplitWindow in XML Markup
GitHub Issue | n/a |
---|---|
Type | Improvement |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2015-10-16T17:36:50.000+0000 |
Affected Version/s | alloy 1.7.18 |
Fix Version/s | Release 5.2.0, alloy 1.7.19 |
Components | XML |
Labels | n/a |
Reporter | Benjamin Hatfield |
Assignee | Fokke Zandbergen |
Created | 2015-05-11T18:02:05.000+0000 |
Updated | 2016-01-20T22:59:53.000+0000 |
Description
There is a new Ti.UI.iOS.SplitWindow class (http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.iOS.SplitWindow), which deprecates the old Ti.UI.iPad.SplitWindow class. Currently, Alloy is using the deprecated Ti.UI.iPad.SplitWindow class instead of the new one. If you change the namespace of the SplitWindow element to Ti.UI.iOS, it fails to launch the SplitWindow with the following log output: {noformat} [WARN] Can not add a window as a child of a view. Returning [WARN] Can not add a window as a child of a view. Returning [DEBUG] masterView property must be set to an object of type TiViewProxy [WARN] OPEN ABORTED. _handleOpen returned NO {noformat} Test view: works fine without the ns attribute since it's using the old class. {noformat}Comments
- Fokke Zandbergen 2015-06-29 PR: https://github.com/appcelerator/alloy/pull/689
- Fokke Zandbergen 2015-06-29 Can we please get this in the Alloy version for 4.1.0?
- Fokke Zandbergen 2015-10-16 Updated PR to address issues.
- Feon Sua Xin Miao 2015-10-16 PR merged.
- Eric Wieber 2016-01-20
Verified fixed, using:
MacOS 10.11.3 (15D21)
Studio 4.4.0.201511241829
Ti SDK 5.2.0.v20160114021251
Appc NPM
Appc CLI 5.2.0-232
Xcode 7.2 (7C68)
Node v0.12.7
Java 1.7.0_80
No warnings/errors appear when using the
element (with or without the ns chage, since it is now changed to Ti.UI.iOS). Used the provided sample code and removed the ns property.