[ALOY-1272] Building an alloy project with Titanium CLI on Windows fails

GitHub Issue	n/a
Type	Bug
Priority	Medium
Status	Closed
Resolution	Fixed
Resolution Date	2015-06-04T00:33:09.000+0000
Affected Version/s	Alloy 1.6.0
Fix Version/s	Alloy 1.6.1
Components	n/a
Labels	qe-4.0.0
Reporter	Ewan Harris
Assignee	Feon Sua Xin Miao
Created	2015-05-22T21:15:59.000+0000
Updated	2015-06-11T17:29:25.000+0000

Description

When building an Alloy project on Windows using the Titanium CLI the build fails with the following error

TypeError: Arguments to path.join must be strings
    at f (path.js:204:15)
    at filter (native)
    at exports.join (path.js:209:40)
    at D:\Titanium_Studio_Workspace\test123\plugins\ti.alloy\hooks\alloy.js:105:15
    at exithandler (child_process.js:641:7)
    at EventEmitter.emit (events.js:98:17)
    at maybeClose (child_process.js:735:16)
    at ChildProcess._handle.onexit (child_process.js:802:5)
---------------------------------------------
    at exports.execFile (child_process.js:691:9)
    at exports.exec (child_process.js:578:18)
    at D:\Titanium_Studio_Workspace\test123\plugins\ti.alloy\hooks\alloy.js:97:7
    at C:\Users\Francois\AppData\Roaming\npm\node_modules\titanium\node_modules\node-appc\node_modules\async\lib\async.js:567:21
    at C:\Users\Francois\AppData\Roaming\npm\node_modules\titanium\node_modules\node-appc\node_modules\async\lib\async.js:246:17
    at C:\Users\Francois\AppData\Roaming\npm\node_modules\titanium\node_modules\node-appc\node_modules\async\lib\async.js:122:13
    at _each (C:\Users\Francois\AppData\Roaming\npm\node_modules\titanium\node_modules\node-appc\node_modules\async\lib\async.js:46:13)
    at async.each (C:\Users\Francois\AppData\Roaming\npm\node_modules\titanium\node_modules\node-appc\node_modules\async\lib\async.js:121:9)

Steps To Reproduce

1. On a Windows machine using the Titanium CLI create a new project ti create 2. Convert the project to Alloy using alloy new from within the project directory 3. Run the project using ti build

Actual Result

The project build will fail with the error above

Expected Result

The project should build successfully

Comments

Feon Sua Xin Miao 2015-05-27 [~eharris] Nice! (y)
Feon Sua Xin Miao 2015-05-27 master: https://github.com/appcelerator/alloy/pull/690 1_6_X: https://github.com/appcelerator/alloy/pull/691
Praveen Innamuri 2015-06-04 PRs merged.
Eric Wieber 2015-06-11 Verified fixed, using: MacOS 10.10.3 Studio 4.0.1.201506022004 Ti SDK 4.1.0 Appc NPM 4.0.0 Appc CLI 4.0.2-rc3 Ti CLI 4.0.1 Alloy 1.6.1 Node v0.10.37 Java 1.7.0_45 I am able to build an Alloy project on windows when using the Ti CLI.

JSON Source