[ALOY-1319] Support CardView in XML

GitHub Issue	n/a
Type	New Feature
Priority	None
Status	Closed
Resolution	Fixed
Resolution Date	2015-10-20T07:49:03.000+0000
Affected Version/s	alloy 1.7.19
Fix Version/s	Release 5.1.0, alloy 1.7.20
Components	XML
Labels	n/a
Reporter	Benjamin Hatfield
Assignee	Feon Sua Xin Miao
Created	2015-10-14T21:25:12.000+0000
Updated	2015-11-04T18:43:37.000+0000

Description

Titanium SDK 5.1.0 introduces a new view container for Android called CardView. http://appcelerator.github.io/appc-docs/latest/#!/api/Titanium.UI.Android.CardView We should support it in XML and implicitly set the namespace to Ti.UI.Android. Example XML of sample in API docs: {noformat} A long label... A long label... A long label... ... {noformat}

Attachments

File	Date	Size
android_20151020-092910.png	2015-10-20T07:33:09.000+0000	49442

Comments

Feon Sua Xin Miao 2015-10-19 PR: https://github.com/appcelerator/alloy/pull/733 Test app: https://github.com/feons/alloy/tree/ALOY-1319/test/apps/testing/ALOY-1319
Fokke Zandbergen 2015-10-20 Verified PR with SDK 5.1.0.v20151019145227 with the following notes: - The test app should not have the ns attribute (https://github.com/appcelerator/alloy/pull/733#discussion_r42458398) - As attached screenshot shows the text is really small, much smaller then I'd expect. Is that normal?
Fokke Zandbergen 2015-10-20 Ah... for some dark reason we're using system unit in the Harness template: https://github.com/appcelerator/alloy/blob/master/test/projects/HarnessTemplate/tiapp.xml#L27
Harry Bryant 2015-10-29 Verified fixed, I am able to build alloy apps with CardView to Android device & emulator with no issue. Android Device & Emulators (5.1.0 & 6.0) Mac OSX El Capitan 10.11 (15A284) Ti SDK: 5.1.0.v20151028190028 Appc NPM: 4.2.1 Appc CLI: 5.1.0-38 Ti CLI: 5.0.4 Alloy: 1.7.4 Xcode 7.1(7B91b) Node v4.2.1 production *Closing ticket.*
Fokke Zandbergen 2015-11-02 [~htbryant] since this is fixed in Alloy 1.7.20, how can you have verified fixed with Alloy 1.7.4? [~fmiao] the 5.1.0 beta still includes Alloy 1.7.16, which does not have this. Will the 5.1.0 RC/GA have a more recent Alloy version?
Fokke Zandbergen 2015-11-02 [~fmiao] what is even weirder is that 5.0.4 of the CLI has Alloy 1.7.18 and 5.1.0-38 (the beta) has 1.7.16 [~ingo]?
Ingo Muschenetz 2015-11-02 5.1.0-38 was likely before AFTER 5.0.4 GA. You want to check the appc-cli-titanium version. Have you checked the latest versions of appc-cli on preproduction? -41+ should be fine. https://github.com/appcelerator/appc-cli/blame/5_1_X/npm-shrinkwrap.json
Fokke Zandbergen 2015-11-02 But 5.1.0-38 was the version we listed for the 5.1.0 beta https://community.appcelerator.com/topic/3897/sdk-5-1-0-beta-and-studio-4-4-0-beta-now-available I'll use 5.1.0-41 but I was just surprised the CardView part of the 5.1.0 sample didn't work with what we put out as 5.1.0 beta.
Ingo Muschenetz 2015-11-02 I get that. I can tell you what the versions should be and how to fix it. As to what versions got released...[~pinnamuri] and [~emerriman] can inform you there.
Harry Bryant 2015-11-04 [~fokkezb] I apologize for the confusion, I actually tested this with CLI 5.1.0-41 which contains Alloy version 1.7.22. I had not updated my specs template prior to closing the ticket.

JSON Source