Titanium JIRA Archive
Alloy (ALOY)

[ALOY-1374] GitHub Alloy repository is missing CLA check

GitHub Issuen/a
TypeBug
PriorityNone
StatusClosed
ResolutionInvalid
Resolution Date2018-03-07T19:05:38.000+0000
Affected Version/sn/a
Fix Version/sn/a
ComponentsTooling
Labelsn/a
ReporterFokke Zandbergen
AssigneeBruce Wayne
Created2016-03-21T09:35:00.000+0000
Updated2018-03-07T19:05:38.000+0000

Description

It seems the Alloy repository only has a check for Travis, not for the CLA: https://github.com/appcelerator/alloy/pull/770#partial-pull-merging We should add the CLA check

Attachments

FileDateSize
Screen Shot 2016-03-22 at 11.19.00 AM.png2016-03-22T18:20:51.000+0000252492
Screen Shot 2016-03-22 at 19.48.03.png2016-03-22T18:48:17.000+000081321

Comments

  1. Michael Goff 2016-03-22

    [~fokkezb] I see a webbook for CLA in the Alloy repo: !Screen Shot 2016-03-22 at 11.19.00 AM.png|thumbnail!
  2. Fokke Zandbergen 2016-03-22

    But I don't see the check on PRs: !Screen Shot 2016-03-22 at 19.48.03.png|thumbnail!
  3. Fokke Zandbergen 2016-03-22

    Maybe the hook needs to be updated? I think the new CLA server has a different path. Maybe check what the titanium_mobile repository has?
  4. Michael Goff 2016-03-22

    Moved this to an Alloy ticket since DevOps is not involved with setting up github hooks for projects.
  5. Fokke Zandbergen 2016-03-23

    [~ingo] [~fmiao] could you look into the CLA hook for Alloy? Probably needs a change for the new CLA server that we also did for titanium_mobile
  6. Ingo Muschenetz 2016-03-23

    [~fokkezb] No idea. See https://github.com/appcelerator/alloy/settings/hooks/4034859. It's registered and working apparently, though does not show up in PRs.
  7. Ingo Muschenetz 2016-03-23

    [~fokkezb] also made you an admin of the Alloy repo so you can check for yourself.
  8. Fokke Zandbergen 2016-03-23

    [~ingo] could you make me admin for titanium_mobile as well then? No way to compare now.
  9. Ingo Muschenetz 2016-03-23

    [~fokkezb] Done.
  10. Fokke Zandbergen 2016-03-23

    Thanks. Actually, I see PRs on titanium_mobile are randomly missing checks as well: * https://github.com/appcelerator/titanium_mobile/pull/7722 has CLA + CI * https://github.com/appcelerator/titanium_mobile/pull/7875 has CI only * https://github.com/appcelerator/titanium_mobile/pull/5788 has CLA only For Alloy it seems random as well: * https://github.com/appcelerator/alloy/pull/708 has CLA + CI * https://github.com/appcelerator/alloy/pull/664 has CLA + 2 x CI * https://github.com/appcelerator/alloy/pull/627 has CI only All PRs in the last few weeks have only CI for both repos, so it does seem to be related to CLA-1 I can see in the logs from the CLA hook a month ago it response is: 
        OK passed pull_request
    While more recently it is: 
        {"success":true,"request-id":"0070d897-95f7-4ee3-a67a-332b52bbb8cb","key":"clauser","clauser":"OK!"}
    So that seems to be the issue. I will reopen CLA-1
  11. Hans Knöchel 2016-05-18

    There a no checks on recent titanium_mobile PR's as well. Would welcome to get that back.

JSON Source