Titanium

[ALOY-1596] Mobileweb assets copied on alloy new

GitHub Issuen/a
TypeBug
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2018-01-05T17:24:54.000+0000
Affected Version/sAlloy 1.10.9
Fix Version/sCLI Release 7.0.2
ComponentsSamples & Templates
Labelsn/a
ReporterEwan Harris
AssigneeEwan Harris
Created2017-12-19T14:51:40.000+0000
Updated2018-01-19T16:54:27.000+0000

Description

Description

Similar to ALOY-1322, mobileweb assets are still being copied when creating a new alloy app. There's a lot more mentions of mobileweb in the test suite than blackberry I believe so not sure simple this would be, is it actually more involved that just removing the platform/mobileweb folder? [~fmiao] any recommendations?

Steps to reproduce

appc new -t titanium -n mwassets --id com.foo

ls mwassets/app/assets/

Actual

mobileweb assets are there

Expected

No mobileweb assets

Comments

  1. Ewan Harris 2017-12-20 PR: https://github.com/appcelerator/alloy/pull/866
  2. Ewan Harris 2017-12-21 This change caused some runtime errors around OS_MOBILEWEB usage in Alloy, have fixed but need to push
  3. Ewan Harris 2018-01-02 [~fmiao] I think this now makes platform=mobileweb in xml invalid, I'm worrisome of us breaking apps with this change.
  4. Feon Sua Xin Miao 2018-01-02 [~eharris], yeah I'm gonna revert the merge.
  5. Ewan Harris 2018-01-04 New PR: https://github.com/appcelerator/alloy/pull/869 Verification:

    Run appc new

    Check app/assets

    - Should be no mobileweb folder
  6. Abir Mukherjee 2018-01-19 Node Version: 8.9.1 NPM Version: 5.5.1 Mac OS: 10.13.1 Appc CLI: 7.0.0-master.6 Appc CLI NPM: 4.2.11 Titanium SDK version: 7.0.1.GA Validated fix with this environment.

JSON Source