[ALOY-1630] Remove LocalStorage as sync adapter from new model creation

GitHub Issue	n/a
Type	Improvement
Priority	High
Status	Resolved
Resolution	Fixed
Resolution Date	2018-09-14T11:35:03.000+0000
Affected Version/s	Alloy 1.13.2
Fix Version/s	n/a
Components	n/a
Labels	n/a
Reporter	Rene Pot
Assignee	Feon Sua Xin Miao
Created	2018-09-11T15:52:16.000+0000
Updated	2018-09-14T11:35:03.000+0000

Description

In the latest version of Appcelerator Studio (5.1.1) there still is an option to create a new model for localStorage. However, you need mobileweb for that, and that has been removed already as a target. Therefore the localStorage property should be removed from this dialog

Attachments

File	Date	Size
Screen Shot 2018-09-11 at 17.52.00.png	2018-09-11T15:52:14.000+0000	87184

Comments

Ewan Harris 2018-09-11 I'm not 100% certain (and am not familiar enough with the Studio codebase to be sure) on this but based off similar dialogs in Studio (for example the new project screen), this is probably populated by calling alloy info adapters, which returns a json object representing the supported adapters like the below.

   {
       "properties": {
           "Description": "Local persistence adapter that uses Ti.App.Properties storage",
           "platforms": [
               "android",
               "ios",
               "mobileweb",
               "blackberry",
               "windows"
           ]
       },
       "sql": {
           "Description": "Local persistence adapter that uses SQLite storage",
           "platforms": [
               "android",
               "ios",
               "blackberry",
               "windows"
           ]
       },
       "localStorage": {
           "Description": "Local persistence adapter that uses HTML5 localStorage API",
           "platforms": [
               "mobileweb"
           ]
       }
   }

Kondal Kolipaka 2018-09-13 You're right [~eharris]. Studio is calling the appc alloy info adapters command to fetch the adaptors. https://github.com/appcelerator/titanium_studio/blob/ed32875ff313fdcbf2de7b14b72619562ca79e96/bundles/com.appcelerator.titanium.alloy.core/src/com/appcelerator/titanium/alloy/internal/core/AlloyManager.java#L408 I'll move the ticket to the CLI
Rene Pot 2018-09-14 Looking good! Lovely quick fix!

JSON Source