[ALOY-1642] Investigate why ALOY-1641 was not caught by tests/eslint
| GitHub Issue | n/a |
|---|---|
| Type | Story |
| Priority | None |
| Status | Open |
| Resolution | Unresolved |
| Affected Version/s | n/a |
| Fix Version/s | n/a |
| Components | n/a |
| Labels | n/a |
| Reporter | Ewan Harris |
| Assignee | Ewan Harris |
| Created | 2019-01-15T20:49:19.000+0000 |
| Updated | 2019-11-18T14:36:24.000+0000 |
Description
I borked on, ALOY-1641 but it is something that should have been exposed by tests and/or linting, but it wasn't and I'm perturbed as to why, this should be investigated and actioned upon. The relevant Jenkins jobs are
Master after updating version passed - https://jenkins.appcelerator.org/job/cli/job/alloy/job/master/87/
Master after PR merged failed - https://jenkins.appcelerator.org/job/cli/job/alloy/job/master/86/
PR passed - https://jenkins.appcelerator.org/job/cli/job/alloy/view/change-requests/job/PR-918/1/
At first glance the linting looks to turn off no-undef as a blanket rule over the whole repo, it should be selectively disabled. I started a WIP a long time ago to move alloy to eslint-config-axway and should finish that.
Looks like the tests in the failing cases ran against 7.5.0, whereas in the passing cases it ran against 8.1.0. I think maybe we could update the Jenkinsfile to run the tests against master and whatever latest points to so we can test GA and bleeding edge SDKs to ensure we catch these. For a quick fix though the I think we could update it just ensure we're always using GA for now
CI improvements here https://github.com/appcelerator/alloy/pull/921