[ALOY-1682] Alloy: MomentJS upgrading to v2.24.0

GitHub Issue	n/a
Type	Improvement
Priority	Critical
Status	Closed
Resolution	Fixed
Resolution Date	2019-06-20T13:21:57.000+0000
Affected Version/s	n/a
Fix Version/s	CLI Release 7.1.0, Alloy 1.14.0
Components	Builtins
Labels	n/a
Reporter	Ahmed Mohamed
Assignee	Ewan Harris
Created	2019-04-01T06:27:56.000+0000
Updated	2019-06-20T13:21:57.000+0000

Description

Upgrade Titanium Alloy to use new MomentJS version 2.24.0 that was released at Jan 2019 [*Changelog*](https://github.com/moment/moment/blob/develop/CHANGELOG.md)

Comments

Ewan Harris 2019-04-01 Previous PR and ticket for reference https://github.com/appcelerator/alloy/pull/884 ALOY-1603. Note, we should also update the builtin locales
Ewan Harris 2019-04-02 PR: https://github.com/appcelerator/alloy/pull/928

Samir Mohammed 2019-06-20 *Closing ticket*, Fix verified in CLI Version 7.1.0-master.21 Able to see the update to MomentJS within the code and tested using the moment sample app. *Test steps*

Create a new application with the moment template

   appc new --testapp advanced/momentjs

Added new lags in the `index.js` along with their related `requires`

e.g.

   var langs = [
   	'en', // default
   	'es', // added automatically since it's in the "i18n" project folder
   	'de', // added via require() below
   	'fr', // added via require() below
   	'az',
   	'bg',
   	'bm'
   
   ];

   require('alloy/moment/lang/de');
   require('alloy/moment/lang/fr');
   require('alloy/moment/lang/az');
   require('alloy/moment/lang/bg');
   require('alloy/moment/lang/bm');

ran the application

Clicked through the languages

*Test Environment*

   SDK: 8.0.2.GA
   iphone 6 (12.2)
   Google pixel XL (7.1)
   Operating System
     Name                        = Mac OS X
     Version                     = 10.14.4
     Architecture                = 64bit
     CPUs                      = 8
     Memory                      = 16.0GB
   Node.js
     Node.js Version             = 10.13.0
     npm Version                 = 6.4.1
   Appcelerator CLI
     Installer                   = 4.2.14-3
     Core Package                = 7.1.0-master.21
   Titanium CLI
     CLI Version                 = 5.2.1
     node-appc Version           = 0.2.49

JSON Source