Titanium

[ALOY-209] ti.physicalSizeCategory module removed for Alloy 1.0.0 (TiSDK 3.0+)

GitHub Issuen/a
TypeStory
PriorityHigh
StatusResolved
ResolutionFixed
Resolution Date2013-01-21T22:07:51.000+0000
Affected Version/sn/a
Fix Version/sAlloy 1.0.0, 2013 Sprint 02
ComponentsRuntime
LabelsGA-candidate
ReporterTony Lukasavage
AssigneeUnknown
Created2012-08-28T07:15:00.000+0000
Updated2018-03-07T22:25:53.000+0000

Description

update

The ti.physicalSizeCategory is being removed from Alloy for version 1.0.0. Its usage will be replaced by the Ti.Platform.Android.physicalSizeCategory API present in TiSDK 3.0+. Developers have probably never used the module directly, as it was just there to support the Alloy.isTablet and Alloy.isHandheld functions.

original

The ti.physicalSizeCategory module is necessary to allow us to handle device queries based on device size on Android. As of this [pull request](https://github.com/appcelerator/titanium_mobile/pull/2610), this functionality has been integrated into titanium_mobile. The first version to have this change available, though, will be 2.2.0 (3.0). We have a couple options:

We could leave it how it is and have ti.physicalSizeCategory added to all apps

We could inspect the build details of each app and only add the module for Android apps lower than 2.2 (3.0)

Alloy could only support 2.2.0 (3.0) or higher

Obviously #3 would be the easiest, and may also be necessary for ALOY-210

Comments

  1. Russell McMahon 2012-08-28 I'll talk to Gabe
  2. Tony Lukasavage 2012-08-29 Yeah, this will essentially be determined by ALOY-211
  3. Russell McMahon 2012-08-31 Alloy will need to support 2.1 and up so number 3 is out. Number 1 is not good so #2 should be the fix.
  4. Tony Lukasavage 2013-01-21 ti.physicalSizeCategory module removed, all uses replaced with Ti.Platform.Android.physicalSizeCategory.

JSON Source