[ALOY-239] Remove "vendor" folder
| GitHub Issue | n/a |
|---|---|
| Type | Story |
| Priority | High |
| Status | Reopened |
| Resolution | Unresolved |
| Affected Version/s | n/a |
| Fix Version/s | n/a |
| Components | Runtime, XML |
| Labels | n/a |
| Reporter | Tony Lukasavage |
| Assignee | Feon Sua Xin Miao |
| Created | 2012-08-30T11:47:36.000+0000 |
| Updated | 2015-09-23T14:46:36.000+0000 |
Description
The
vendor folder is not documented and simple provides a name-specific way to organize files that would otherwise be stored in libs. To simplify Alloy, let's remove it.
also removed "modules" test app that relied on "vendor"
In what way is this folder removed? The compiler still copies vendor folders: https://github.com/appcelerator/alloy/blob/master/Alloy/commands/compile/index.js#L174 I can understand this is still there not to break old tests, but if you don't want people to use it at least it should give a warning when you do.
This has not been removed at all and I'm not sure if we should or maybe even make it official since it's a convention used in many software to hold third party libraries injected by build tools and package managers and thus should be ignored for versioning. https://github.com/appcelerator/alloy/blob/master/Alloy/commands/compile/index.js#L189