Titanium JIRA Archive
Alloy (ALOY)

[ALOY-25] Replace eval() of runtime w3c libraries with require()

GitHub Issuen/a
TypeImprovement
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2012-07-19T11:52:02.000+0000
Affected Version/s2012 Sprint 14
Fix Version/s2012 Sprint 14
ComponentsRuntime
Labelsn/a
ReporterTony Lukasavage
AssigneeTony Lukasavage
Created2012-05-11T11:28:36.000+0000
Updated2014-06-22T13:21:25.000+0000

Description

In an effort to protect scope and improve modularization, we will be replacing all eval() calls for the following w3c libraries with commonjs require(). * xmlsax.js.opn * xmlw3cdom.js.opn * xmlxpath.js.opn As these libraries were not designed as commonjs modules, some care will have to go into how they are created as such.

Comments

  1. Tony Lukasavage 2012-05-11

    There's also the consideration that these libraries are LGPL, so I'm not entirely certain if we are allowed to change them. And we would almost certainly have to change them as right now there is no means of using them meaningfully with a commonjs module.
  2. Tony Lukasavage 2012-05-18

    Check these commits for details: * [https://github.com/appcelerator/ZipTi/commit/6e39ebffd41983b14b08e97cb04bdd7bc4e93742](https://github.com/appcelerator/ZipTi/commit/6e39ebffd41983b14b08e97cb04bdd7bc4e93742) * [https://github.com/appcelerator/ZipTi/commit/904aa1bcc185eb01113b25a8375128fcbee9f3fd](https://github.com/appcelerator/ZipTi/commit/904aa1bcc185eb01113b25a8375128fcbee9f3fd)

JSON Source